[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 2/9] iommu/arm: Add iommu_dt_xlate()
- To: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 10 Nov 2023 09:39:43 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VA/MDRhUT/rDnENS7ezaXAuZsVISm+LSgUQlhipzdk8=; b=VNsoBiwhw8o3wmbmPoKfhrtjjkXghyITd4BqR/ihWRn6F9bbo4ZhzWB/Opk+cfGQMYPeT3LksVwzC/wbo6e0UtBZpxwLttHBNSi8Rd4AOYWUroiRXtXR4tOSQnqqvPJRqC6/udMPWeJeL59BSAM2v0NEZ61XPrRu4nQVsSy7FlMFw5ZoxBjiseA/z4H0OnNU9IFCLB7ljn//w9nC9E7/h4w78XWAdXBeVduiduRWt+Q5z6dpCag5bktXLnqY43hmI/D51C2xs/3FTUpn8an+J9DkdO6mUr1ETxKTEIHNE/Lcb11l2Qzm8VXZXb2vG94GC+69KjdV24x8SS6FFopg5A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OYTLiym4TFOim6IVoata7pXmNIYaDv5yDw2omInXWKlIguQGUQg9I5RGVuWYO1wVnjPi7NE8hPZNwNtb27GmaddKXJURlFmQEukcZi+LX6KoujQ8QF/TI5xpyudccU25+cN84ij/yndeVLSF2I86t/cUFt0gsgxY+jTMuOlQxrR4SztsTL9A45ng2SllGVRY/6iheQZVcx4Hg/5U1VURE38cEg72MFugHb4l4RUUl1CC9LOgLcVn2ath+zQhe7XgdgCO4+SmXw7pka4d4Juzov8roxf3KJ7jdMRcsYHTY2QYZipCVtfEz7UjT0aA3c0EZsXTYXfEiv5jyyQ7TatkIg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 10 Nov 2023 08:40:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09.11.2023 19:27, Stewart Hildebrand wrote:
> --- a/xen/include/xen/iommu.h
> +++ b/xen/include/xen/iommu.h
> @@ -245,6 +245,8 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct
> domain *d,
> */
> int iommu_remove_dt_device(struct dt_device_node *np);
>
> +#define NO_IOMMU 1
> +
> #endif /* HAS_DEVICE_TREE */
When looking just here (i.e. once that was committed, when looking just at
the header) it is entirely unclear what this #define's purpose is. My first
guess was a bogus attempt to escape using some CONFIG_* setting. Looking at
the use sites, this looks to be a kind-of-error-code. That wants saying
here in a comment, alongside the scope of where this may be validly used.
Jan
|
