[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH] automation/eclair: add a deviation for MISRA C:2012 Rule 8.6
- To: Federico Serafini <federico.serafini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 10 Nov 2023 13:41:59 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ht6CGAYDcXqbjiDKoDntInmLwGLqvjlsjR2Iy3UMjeU=; b=Np8Nuoj5Csy249aaOGD9iwshZZ/JHDihdTDDBTbz1GuSQ2ejJJpNdV8UnHCLzDvsV1GW10NcXh9nTXkb4vgE87zfuaSfFkzIuPLqH1lCYIQNS6bILXH4RWf0mJ1nhBk8oFf7+1W3xyZsh4Oe1oomJkqBKhqjyoSmazZEoyr4smBWkmnA3Ty/QmmfU8zDl2rJBaivJT1LZO0LUAMT/7yDwfxtV60W5U4MpB4440cZO2D/5MEXmz0Ufza1Oy3op0BhTfqBH3j/vxfOHgAkesuK5CV3W7ZTDtQdzUbuYnrxw89hfktuhwkqPUGvzHr62m0G/jRnPOLIr1dfL6S0q8p1XQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iG4eYuge8ccNa6lj4JOJfd9t0ej/6UAYs5HuKEbfLGAIlRkY++l3ou2IzhZ5CZjV2BBKMEa6bZXOv713ITr9yIfrvmzGPyv6+Vp/mSQxQ0PdXveTedQ24Yh7VQT9Vn93hs2lpndRzh25n7q2HrXJPTHiMNAumQRCxsfIxQpUQpMu8AFA9PaGvAOg9ZuZeywQCpNPcPf9d5fuY9zQGf/HkYIBo6aaAg1ryjkzMg1nWidQUQJ6sxh6M9hd6YdRXe97x9bHW6FrxwhfP3Yz62VJ9oFnNsP9QIPB1ZlAQPnLMLsBJ6vVN95WlviMg0QzsNgErYNCNiZDyBNFLxlzWfDCDA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: consulting@xxxxxxxxxxx, Simone Ballarin <simone.ballarin@xxxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 10 Nov 2023 12:42:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10.11.2023 12:23, Federico Serafini wrote:
> --- a/automation/eclair_analysis/ECLAIR/deviations.ecl
> +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl
> @@ -214,6 +214,15 @@ definition is compiled-out or optimized-out by the
> compiler)"
> -config=MC3R1.R8.6,reports+={deliberate, "first_area(^.*has no definition$)"}
> -doc_end
>
> +-doc_begin="For functions memcpy(), memmove() and memset(), if there are
> +multiple definitions, those belong to different archives and the behavior of
> +linking is well defined by the toolchain: only one of the definitions will be
> +linked in (the first that is encountered searching the archives in the order
> +they appear on the command line)."
> +-config=MC3R1.R8.6,declarations+={deliberate,
> "name(memcpy||memmove||memset)"}
> +-doc_end
Why would this be limited to mem*()? Anything put into lib.a is going to
be treated like that.
The description also isn't quite accurate: Per-arch mem*() won't be put
in archives, but in .o files. Those are always linked in. Anything not
otherwise resolved may then be resolved by picking objects from
archives (appearing later on the command line, unless specially grouped).
> +
> +
Nit: No double blank lines please.
Jan
|
