[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Clang-format configuration discussion - pt 1
- To: George Dunlap <george.dunlap@xxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Mon, 13 Nov 2023 15:28:26 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yIdcjh8GTqbof6QVLq/iuNdGDsY94HJxNcCXRGGW+rI=; b=SRQnRsiBNPR2LLhCQv0btZGzk+ATjvAXuQvEcAYlkAO1Li/LFQz3LL47FVMrnHfEYbDw56GVSuV1lCSz3Ziqp9qkNUkvEH40Sobi8pxd1PiUZlw8k+OEa0PKQZe1fqQD/JH/9LwbSknXai54GEWJ8uOL5buh0O+HDGEnJ8mtlRTIVAjkr2903SdwHM/aGvOoX9S4SIPWv0QZeLNZk95SvwJqtnjrfJk1+Fa6mrUyeI4nAUacnkQbocmIaSiS4ojEpnuEauA5ueCCbnpQxaTWD5Z2dBEoBo4JrtSgaY1gywYUW/FOfhauz/TDJbhpdwD46wOxkWJL1D2zhoendWgvcA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yIdcjh8GTqbof6QVLq/iuNdGDsY94HJxNcCXRGGW+rI=; b=AAvcMxmZI8fltbhfw5km4WHAZ7+ynhzyFzyX5In0/OJHJn7gbwhhZZU/mYUySmDnNPTIyR11CG+gFelmyWcRSzK1eFia18C81fdQu12SiYkx2+BmIOIgmzm/gDABKoaAuPY6arpPctDcybQQIyQhJ1cEhLn8TgojvLAUp1+ZuVnQhhDOLaAFojmhW5+gni7T3JQYK6nZS9W9c1RxW/NvwywFXJD1+SJnbMcfHzW0j+BBYWqXqRHncExOWE1SqRapI2KMIJ1P6PyFJa6VlFd0ZbomhBUCVddLRAgI9Bz+iu9bYnn4zMnYqHm3Wy1N+IWu28FDMVDRW6UMDds5EUe7Wg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=b+vPHVLv9DgaDIpsV4G/GvndoObaR+YaTA9XmT36br/3/x07aKBU1cb9qvcNz/XM7oB6S0+gJ0hYTMUnUbJjSM7lmyKuYE1i3D3n0NPB1n6OaXgB0dsbW0PmmAYhXxiTpzeBgm/cVLNUAGpAH0HmBa/Z8zXjf2SZa0ihZYszXWOT2oKPUtRcj9YB+9vyzXeFEXvfTVsn8RVV9wsUMyG8YaHIg10gwIpOO/VZChHsGvKy4UZIy8qhGQ7BR/KQBspPN4k+rD1J9Fv23Ykz6LOZX2oprkyFn71m43CkRsb6quqeu4ChjqUKjUtub4XSUdHnzZroEmGz0wUsDfCHdGGXtA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kkzESVq4edIQDXqtAS/A8R5qK5NixCsQMi0v6MDFO0OlGlSyFw63DZH+U0q/Ml+7WGzNcOt73CB3YOAycjY2OKPa4/rv1ucO6cpmmq17nSCts3Pf0DMjawSOdrZxUVexEv8oejflP6pBwfYmQmTeBQ1ZKGPNePiDEK8hwjnr6batrC3tN+1TMEtO17WZCoAt7b6ukcVV5oae0dCYMi92jpJFqk834Vk97nECUFPA1n6DkwZIc2ecDza8Lbfh6tIslTEGQc2oJ5TSnH/bnC4fmjNhYHkKTMYzDbC3Tqo4z228YgzjPOWD2z6ND2ncP/OUjF6KvapsjbK6ITgIXju8aQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <Michal.Orzel@xxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Mon, 13 Nov 2023 15:29:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHaEild8psuTSSrb0SmQq+9AXKRR7B4Sv6AgAAcuYA=
- Thread-topic: Clang-format configuration discussion - pt 1
Hi George,
Thanks a lot for taking the time to have a look on that.
>
> Luca,
>
> Thank you so much for the work that you've done here.
>
> The approach in your v2 series looks plausible, as does a brief
> overview of the items in this list.
>
> One problem I have is how to really evaluate the proposed changes. I
> spent a few minutes skimming through the "megadiff" [1] output from
> the v2 series, and while everything looked fine, that is a HUGE patch
> to skim through. I don't really have any way to know if there's some
> rule introduced that I don't really agree with.
>
> On the other hand, I want to avoid busy make-work and the invitation
> to interminable bike-shedding discussions.
>
> Is it possible, for instance, to start with a diff which will enforce
> *just these settings* (column width, indentation, and so on)? And
> then add on new coding style changes one (or a few) at a time, in a
> way that would make it easier to understand what effect each change is
> having? If so, do you think that's a reasonable approach?
>
> If not, how do you propose to proceed?
Yes they are a lot of modifications, the issue is that when we don’t specify
a configurable, the default option will take place, so it’s not really feasible
to produce an output where only the specified configurable will affect the
format.
The easiest, but difficult at the same time, way I thought we can proceed is
discussing a set of rule at the time where we all (well the maintainers) agree
in principle, so that we apply them to the codebase until the list is completed
and also CODING_STYLE can reflect them.
Anyway if someone came up with a better idea, I’m open to suggestions.
Cheers,
Luca
|
