[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 01/15] xen/asm-generic: introduce stub header paging.h
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 13 Nov 2023 17:40:20 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bCmofWasZFXA/cG3KHgVCOndFdYkR6t6yoQqezHEVfQ=; b=ZqLEJZz9ghJwO3dUwxZSI3GaL47RsRDAr0okhPG2UWWq720J1FMiPsUWviLOM0tIKaRdGyaJztXJsbaaRXyuB3nwE5JN1gths8JnYSu5MWzyatMCzL1E44U4FnX7IsRlve2hyqXby4uDTg0mHFQ97GS9hntldMUGPQWOws35jmUyWSaGXjgVuafa7LfmDjBL9b0QKSx5xS+x5vhfSi9FReBmgQj6d2o+QUGGrxLaoaZxdPM8GSymvHIsGLpPJRmsX7j83fBibU1GdkMuwpuhAwASR2Di+0JjBK7rf3WB6/Py9Nqy/29jurW5GxM56ePObKjBNbSlqwxAnM08670GMQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WIMQYytbcpO26ZV5cIKS7nFIjbaSyXzPOkr5mPM+GoFrkarUAbCnpa4u20GINeVoYzBRfvpC5qdGPWdSf/XB0LRGPK72csf57pdvoojjwguG7PM4KQ0JFaPoRybwUaY589dYPeEoR7wr7acAtHN8cKu7kPRnVVgVKmjUQYxBNDHW6KLk8xuN1x4LxK4GUGKrDz7dB7ZMmhUCOIltplVOmCSfme9cF8qdUu3qoxBxBxYc1ZuKAyruZPAA4FDjKpQuxoX32zb2YnRIRjNWNBCspuh4iwcur/zy2popf+rX7KcB4Fz497eCz5v+w0hZAQnxhTK5vQusTCPGpIXGvps3ww==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 13 Nov 2023 16:40:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10.11.2023 17:30, Oleksii Kurochko wrote:
> The patch introduces generic paging.h header for Arm, PPC and
> RISC-V.
>
> All mentioned above architectures use hardware virt extensions
> and hardware pagetable extensions thereby it makes sense to set
> paging_mode_translate and paging_mode_external by default.
>
> Also in this patch Arm and PPC architectures are switched to
> generic paging.h header.
>
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
with one nit (applicable twice):
> --- a/xen/arch/arm/include/asm/Makefile
> +++ b/xen/arch/arm/include/asm/Makefile
> @@ -1,2 +1,3 @@
> # SPDX-License-Identifier: GPL-2.0-only
> generic-y += vm_event.h
> +generic-y += paging.h
Like in obj-y lists it would be nice for the items here and ...
> --- a/xen/arch/ppc/include/asm/Makefile
> +++ b/xen/arch/ppc/include/asm/Makefile
> @@ -1,2 +1,3 @@
> # SPDX-License-Identifier: GPL-2.0-only
> generic-y += vm_event.h
> +generic-y += paging.h
... here to be sorted alphabetically from the beginning. Right here I'd
be happy to make the change while committing, but I'm not going to promise
making the same offer on subsequent changes (should the same issue exist
there).
Jan
|
