[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs
- To: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 14 Nov 2023 10:13:27 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pwS6wxtxzfir+c0ysyPet64hXP4uc+VHcEEin5Vt7BM=; b=SDiFygqzVLCQpHpJg0Ez16WuKj71MfM4nt2eM4DJxtBPGeFyc8fB89H8bt7SJAKhFg8Z1yVYjpBThL8lrrE1ZH6m7nIbujNIoxU7zMqeVKgGXdufNlHb7aYxKwUVECLSUBQQvhfdcPiF821XdvZ+jnQHVfJStBIc+MJrp3j/CXmkzWagVDalS70sbR42SLoKZQxrI6DBNQyeSMZ+NAx/zSx4QLH+x70WRPviCsXUCxKdL8Cm5EHr+NDIYL+Tclcosms1LKHtSv+CUMp1nmXsOSZxpkW7Ztu2Q4iwkOnaTsWg0KZjukQxLVGj6q4lh6+C1UXV3F5qB5peGObHXUTY6w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N8I4VBX3HNNu2zkUadxiQe9CCwfX7oUUCACI4u7aBS1st5G4dajFyI4ASvnqXldyZuk8Rt0/YPifbVS6uxv9TYiJcFBrxb5QB4xywHFw7whJ4TDvKxD96UB6YYl7G63kce6EkZ+Sos5LisG0eohyUHqWXEXky7tbySjZZSrNnz/fx0WOQt2ySBVZh4fNSzklmGn/lfmN20htleb7Rnet0sTmhC7tsxkqGtVt2onCPuOyAExsVudjMmcJqaicuPGKTYAbxpTib6c+3BIYU7XBQalzP/Ikn5bTaQwH6+OksNLNUmm6A5J2DOTuJdBU9Zc/zfQHfavejLazo+L+i0HDIg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 14 Nov 2023 09:13:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13.11.2023 23:21, Stewart Hildebrand wrote:
> --- a/xen/arch/x86/include/asm/domain.h
> +++ b/xen/arch/x86/include/asm/domain.h
> @@ -503,6 +503,8 @@ struct arch_domain
> #define has_vpit(d) (!!((d)->arch.emulation_flags & X86_EMU_PIT))
> #define has_pirq(d) (!!((d)->arch.emulation_flags & X86_EMU_USE_PIRQ))
>
> +#define arch_needs_vpci(d) ({ (void)(d); false; })
See my comments on the v5 thread on both this and ...
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -1542,6 +1542,18 @@ void iommu_dev_iotlb_flush_timeout(struct domain *d,
> struct pci_dev *pdev)
> pcidevs_unlock();
> }
>
> +static bool needs_vpci(const struct domain *d)
> +{
> + if ( is_hardware_domain(d) )
> + return false;
... this. (It is generally a good idea to wait a little with sending new
versions, when you can't be sure yet whether the earlier discussion has
settled.)
Jan
|