[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/7] xen/events: modify internal [un]bind interfaces
- To: Juergen Gross <jgross@xxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>
- From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>
- Date: Tue, 14 Nov 2023 13:45:02 +0000
- Accept-language: en-US, ru-RU
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rvgIiY4anEDmHl5y9qpBSp8F3QqO/H3y5kFh1jYTFtA=; b=MndvonmgYfKA+bPZ2PC/5yrnR6asSjBHx/gVFZXQXdI0H7meysUwZps9RkhnCk4XggyopcVMEQ3CJSrNRI2uSsUXmVEMCJb8OZqOwlQV8mKyLQkKr4LQCb/HMV9T4yUXJAf+aDAeKS7wX9PEUsZ3pyEvsL5CucKT4fNMn6qibMRKsDg895UKRewk3J2DlUebHe5vjPttvIAvlF0kM4hzsi4UdYV1x9lH+Q/ngSGqFdVFKFZX2KT90Ro4fv2zkYeEhGe4oPCNk4MFZtLPsucvMaSV5PmwJbU72+YDhXRIE6vlYm9JF4NN70s1v8gLkVdVaStV+ceD2X41UXHxuruAww==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Filxshp0E9icVNGm3qXt/JCK+Dju2kC1ndACBX3t4SOsLAUjeyAC7oKSmN3FloJkUxZegR3zJt2rfhZe8xgK8DvqRK01QHZBXNqF1rBx7wAjEV2J5LJ1XdeONBxlD0s+Fyh26Hit+3y8+FmQLrUoYd6Mx+JfSraLrMl1NF3g+xdPioHGyHY0S7BXCehcEr7hHnEps2JbnQpIUYKX6dTVoOB1L5hj9FRSkwPTIS7RyNMyn7PaEnuew19V/CnfztguOhWYV4KrRLmUWGfvHWUaq6kXYcRoQ0srIiUO8bfnhOHRSHBj5Tb86pJU5N4gMQMp26hXZX1uXCoUrGolz67zkg==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 14 Nov 2023 13:45:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZ//oVz+DyHlClAkeSP+z9zQ/ubLB6AZEA
- Thread-topic: [PATCH 6/7] xen/events: modify internal [un]bind interfaces
On 16.10.23 09:28, Juergen Gross wrote:
Hello Juergen
> Modify the internal bind- and unbind-interfaces to take a struct
> irq_info parameter. When allocating a new IRQ pass the pointer from
> the allocating function further up.
>
> This will reduce the number of info_for_irq() calls and make the code
> more efficient.
>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
I didn't spot obvious issues with current patch, other than just the
fact that patch needs rebasing (some hunks cannot be applied because of
"e64e7c74b99e xen/events: avoid using info_for_irq() in
xen_send_IPI_one()" went in).
I was going to ask why "pirq_query_unmask()/pirq_from_irq()" wasn't
converted to take a struct irq_info parameter as well, but looking at
the rest I noticed this was already done in subsequent commit.
With proper rebasing:
Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
[snip]
|
