[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 1/7] xen-block: Do not write frontend nodes
- To: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
- From: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Date: Tue, 14 Nov 2023 21:32:05 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GD6941rI2V2b4dRSU+gFi73+GBMXJo2zUuzFUfNaLaI=; b=KX3Clz5Ml8vNNfZ6280/du6EIlfttByBHVoKj9kuwbzlui2anQCE6eVu0JWlRG07Vpx0fjcs6gCEJCITW05L/nfAB3yX6MnqMJD+24GYH+uDushkX07HjR/BaPlnbXphYlGBOFlVySX/f2TWHdtLCAny+XzFVh3ngkpn9atOsdsoGVpcRgAyZI2buRto5N/8Kqnkc0yxybr/l3S+g6zfcUH0bB8ymOqFpFZOIXrnlLwhpaZpVcdtLZXu+WgvUJCA0NAKVe5AIVDcR5pz4GTySHmOaCbifIKhrwLo1gFqBchzV00FsTia4267smbPX+RA4PUkucq4FFlHeFc9Yd+xUA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DjtoCwFGh1bhBklzxDhGdf3z+2X7rhNz4dq83SqPzPZ8iVE07t585o1vZeCnsTVV22xTcceCX9NFfQFIjoG82kcRBPAntJqxx5NglScE8+7RgKw8rDlb3rAo515z750CHeeOtOhKklK/nVp63s8d0NzTDSAGzk+JgnmHhNOq+zlqZWLg5KFFFX0FnAXIf4zJnrVUEjmvfF7MPkuqd+MIJdHXocGtGpN6BPJDz7vgc0sZTMF3SXwHwD6NXXIPTBj+3wyOO7d1NRNA2cQg/9bGNIufLmpDUyS6bCSfHupIsTGH0UuudmZq9TAreBpur+vqYBj0j5nh9CapR/mCHBOKDw==
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "qemu-devel@xxxxxxxxxx" <qemu-devel@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Kevin Wolf <kwolf@xxxxxxxxxx>, Hanna Reitz <hreitz@xxxxxxxxxx>, "open list:X86 Xen CPUs" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "open list:Block layer core" <qemu-block@xxxxxxxxxx>
- Delivery-date: Tue, 14 Nov 2023 21:32:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHaFBZngjGHt2Wnc0CJ36bDt34c6LB08xWAgAAu5gCAAG5XgIAAGewAgAAIwICABKNGAA==
- Thread-topic: [PATCH v1 1/7] xen-block: Do not write frontend nodes
Hi David,
David Woodhouse <dwmw2@xxxxxxxxxxxxx> writes:
> On 11 November 2023 16:51:22 GMT-05:00, Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx> wrote:
>>On 11/11/2023 8:18 pm, David Woodhouse wrote:
>>> On 11 November 2023 08:43:40 GMT-05:00, Andrew Cooper
>>> <andrew.cooper3@xxxxxxxxxx> wrote:
>>>> Furthermore, the control domain doesn't always have the domid of 0.
>>>>
>>>> If qemu wants/needs to make changes like this, the control domain has to
>>>> arrange for qemu's domain to have appropriate permissions on the nodes.
>>> Right. And that's simple enough: if you are running QEMU in a
>>> domain which doesn't have permission to create the backend
>>> directory and/or the frontend nodes, don't ask it to *create*
>>> devices. In that case it is only able to connect as the backend for
>>> devices which were created *for* it by the toolstack.
>>>
>>> The criterion used in this patch series should be "did QEMU create this
>>> device, or discover it".
>>>
>>
>>Yeah, that sounds like the right approach.
>
> I think we want to kill the xen_backend_set_device() function and
> instead set the backend as a property of the XenDevice *before*
> realizing it.
Not sure that I got this. Right now device is property of
XenBackendInstance. Are you proposing to make this other way around?
Right now I am looking for a place where to store the information of
XenDevice creator. My plan was to add "found_in_xenbus" property to
XenDevice and set it in xen_backend_device_create.
--
WBR, Volodymyr
|
