[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH 7/7] xen/events: remove some info_for_irq() calls in pirq handling
On 14.11.23 19:16, Oleksandr Tyshchenko wrote: On 16.10.23 09:28, Juergen Gross wrote: Hello JuergenInstead of the IRQ number user the struct irq_info pointer as parameter in the internal pirq related functions. This allows to drop some calls of info_for_irq(). Signed-off-by: Juergen Gross <jgross@xxxxxxxx>Looks good, so Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx> Just one NIT below ... [snip]-static void pirq_query_unmask(int irq)+static void pirq_query_unmask(struct irq_info *info) { struct physdev_irq_status_query irq_status; - struct irq_info *info = info_for_irq(irq);BUG_ON(info->type != IRQT_PIRQ); - irq_status.irq = pirq_from_irq(irq);+ irq_status.irq = info->u.pirq.pirq;... what is the reason to open-code pirq_from_irq() here? For example, __startup_pirq() continues to use helper in almost the same situation ... Good catch. I'll change that, especially as it allows to remove the BUG_ON() which is in the helper already. Juergen Attachment:
OpenPGP_0xB0DE9DD628BF132F.asc Attachment:
OpenPGP_signature.asc
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |