[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] misra: add R21.1 R21.2
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 15 Nov 2023 09:00:39 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rAUYGU4iLjkXQno90F86DkqwULbVdUfXxlOCMNJfV7g=; b=Y42wqVQ6F7W+PxBMcKFT+3DfheFr9ALWziYlfarmL0ICWv86qtlJT1yLLxUJ2Zg844Bpu9m6fQYXDfkGUm4tCDJqJ10+FBaJqJOYqj8+myXsYBjYK+BFsz+ps7nnKF2kr3+PZXMm+TPLOfiGsLtYkg1fFNN6Zno+shtJR6RftCmryjgGtb2clRrJnbQbwEJRRZwyEvZAwUPrLRTlG/cAOQYDm0mJxLoygM9yVstXGw9gpb3kwxpZWm49D57Z3SUIWs+nqFDt/d41QVESVe4NGkU3l4YwreYekxkciqxcqLsRVTUMUpro7U4GVLZiDN98+u+/ySL+EdTSUYXT1npUwQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UD1jByHpBqgsdpV0cmMlAyoODlUPruVFSPt54FwgLei7VeyBJzoWntb3zxDNFW6ql/88gHh0dMakTYfi6CLV39ugThRGEAHhcojEdJARscSo+eAPO/U1Ujy1YA+ToE5fV0J+wcI37DaVI5IVBP27vpifPB+NRah71SZoWnDWbKqiv1GiQPRFeBR8fdOThC/WjVIJ36ZtdJylXbXpPlLTxoRiXbAUo2Nv4vzuo7/raDjmTvPdjGBbBGTpNh2d1y33k6rzNZrj3+DwQHkjPGldSqptAAhBGMU4uhEnnrflfZbq8A4Aw3d3DVxKx7Z6v254LprBgyc09BouJiGjZwfnBw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Julien Grall <julien@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 15 Nov 2023 08:00:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14.11.2023 23:59, Stefano Stabellini wrote:
> Add 21.1 and 21.2, with a longer comment to explain how strategy with
> leading underscores and why we think we are safe today.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
with one nit:
> --- a/docs/misra/rules.rst
> +++ b/docs/misra/rules.rst
> @@ -519,6 +519,28 @@ maintainers if you want to suggest a change.
> they are related
> -
>
> + * - `Rule 21.1
> <https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_21_01.c>`_
> + - Required
> + - #define and #undef shall not be used on a reserved identifier or
> + reserved macro name
> + - Identifiers starting with an underscore followed by another underscore
> + or an upper-case letter are reserved. Today Xen uses many, such as
> + header guards and bitwise manipulation functions. Upon analysis it
> turns
> + out Xen identifiers do not clash with the identifiers used by modern
> + GCC, but that is not a guarantee that there won't be a naming clash in
> + the future or with another compiler. For these reasons we discourage
> + the introduction of new reserved identifiers in Xen, and we see it as
> + positive the reduction of reserved identifiers. At the same time,
> + certain identifiers starting with an underscore are also commonly used
> + in Linux (e.g. __set_bit) and we don't think it would be an
> improvement
> + to rename them.
I think this last sentence would also better say "two underscores".
Jan
|
