[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] xen: remove <asm/delay.h>
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 15 Nov 2023 11:24:25 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c2FVv9fr9XR75GmCVpbnT3Pr0kF7q9c4qjPidqUYGyU=; b=JEmnCVqblgjgCCx5ipr216vakPqYwaCt7iN5hGyL09RSdjTXsGP9SIZH0FEU3d1xQydW71KM5uCHAo/lJ+24SJKq9FOZWSl6JGcE8c1WuP4PFPjINJSKZ74ESHYdTa20WRGMSTcujZhsDs+jGeYjyOxBe1+/MXiKPffMcoM2HHKAu+Pu6abAa5gfUwnzKu8IVqms3ER7qkzSmDuPXBEvy/3C5NeFycHpLfN5viXucLLcF2/vob6RSxdGZELWPZZJV/qvUp/Eqpf0Ow8atYM2DwpclPOnDgf9k/DRcquulMPslgE45eiiWAdgOhMXViCz0UnEhOpRgNmmlF6L12BzyA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ib1sxWhHu7sjO4NnycM631GH/lDQREK2t5qcQGpWUQvokzK2nSlPrTBoNGv0R0xbGR9Y8WF945lsOzr4MPpXYuAVY7xB9aH79EnBJ/TXuDcnF64xWM7ZFh7/4Ly80z7oqIPT9JaSK0bmRvtS+71pmm57SdCLsk3HwqRPaIhPY65VXRJWPO47YnJcni3AVemUgM61ZbZMEcnmNMZU3RnBY1Wdo5Hdak83QKcVBqzQMEJfKIgYfCYdipzjVwKNAJpftTbbrNPJ3jIJAjvTg2aHx44h/tmlg365NkcJwOoor8s1xe+55UlCgom560Ogach63RAJpBrzQE3HncPI2Uu6qw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 15 Nov 2023 10:24:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 31.10.2023 15:28, Oleksii Kurochko wrote:
> <asm/delay.h> only declares udelay() function so udelay()
> declaration was moved to xen/delay.h.
>
> For x86, __udelay() was renamed to udelay() and removed
> inclusion of <asm/delay.h> in x86 code.
>
> For ppc, udelay() stub definition was moved to ppc/stubs.c.
>
> Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> Changes in v2:
> - rebase on top of the latest staging.
> - add Suggested-by:/Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>.
> - remove <asm/delay.h> for PPC.
> - remove changes related to RISC-V's <asm/delay.h> as they've not
> introduced in staging branch yet.
> ---
> xen/arch/arm/include/asm/delay.h | 14 --------------
> xen/arch/ppc/include/asm/delay.h | 12 ------------
> xen/arch/ppc/stubs.c | 7 +++++++
> xen/arch/x86/cpu/microcode/core.c | 2 +-
> xen/arch/x86/delay.c | 2 +-
> xen/arch/x86/include/asm/delay.h | 13 -------------
> xen/include/xen/delay.h | 2 +-
> 7 files changed, 10 insertions(+), 42 deletions(-)
> delete mode 100644 xen/arch/arm/include/asm/delay.h
> delete mode 100644 xen/arch/ppc/include/asm/delay.h
> delete mode 100644 xen/arch/x86/include/asm/delay.h
Shawn: As per the diffstat below your ack is needed here. Recently I did
(silently) time out on two sufficiently trivial (PPC-wise) patches, but
this shouldn't become a common pattern.
Oleksii: It is normally on the submitter to chase missing acks.
Jan
|
