[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] livepatch: do not use .livepatch.funcs section to store internal state
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 16 Nov 2023 13:39:27 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fHIfcmj6E1PwL20jkxNFnHfm4Et4OmYycWyT/yJu8X0=; b=MEBlwXQNAC4epchvCDvBasvsqZXbm3w2sosEc0JfXQCTAu3WYH+bbeofcOKlmlcEs2fxWM9DxIVwUtnJxv6aj2EB1hYp3iV9uz6/ZYFjeFsjgJ9WT92iFwW4OtfirmIZMPRXzzu968/TaJ0Ka+ZWLfvAEenh1Gm7bsjTPLwvrWD8FGWaSywB9VIQjwSv4+XOtd+4g9BHUiOJ3HX8ZuO576giVBMkimSpEjB2bqXqFT2dQFbJp6NyimiPu+F2e7Sxh7koaMk7Dt6nNNwYsGBaX306HOU3c61956Wxn+C7q9rTQKUiZV2AjOwRp+O9bxEh6X/tyZLjoVVBWjjDdfZMvw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nagVg8ut7ZAZGzeMSPaOZpp+49KWOFW7+YT9I18FU9LVaaALsEUKeENsuLdI+8923ufMdOJL4yT57e2KNQkOgc6LrOtTG97UftUk5dOkHaBtVnCEIZCHu4IwIIQwc4oVjJt94xsMjQQFZ9YuHSdyW0xI+Ds8CCaCBSGWzXC/AeytDT85SvA5UPp+h0qEWGfQDowgD+fFYsobrbtHD9kKjvekOvOwvwevGZNsqJ6njPPfZxZF33nRlhflXSzgnPgNawytqiqXasNRD4VHhEX2Df8x8VuPavnhKyatcm17HolfcqTK6yDEsuIxhYmOYB0gbtgS7n1cepJGdk+BZI25HA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
- Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 16 Nov 2023 12:39:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16.11.2023 12:58, Roger Pau Monne wrote:
> --- a/xen/include/public/sysctl.h
> +++ b/xen/include/public/sysctl.h
> @@ -991,10 +991,7 @@ struct livepatch_func {
> uint32_t new_size;
> uint32_t old_size;
> uint8_t version; /* MUST be LIVEPATCH_PAYLOAD_VERSION. */
> - uint8_t opaque[LIVEPATCH_OPAQUE_SIZE];
> - uint8_t applied;
> - uint8_t patch_offset;
> - uint8_t _pad[6];
> + uint8_t _pad[39];
Should this be LIVEPATCH_OPAQUE_SIZE+8 and ...
> --- a/xen/include/xen/livepatch.h
> +++ b/xen/include/xen/livepatch.h
> @@ -13,6 +13,9 @@ struct xen_sysctl_livepatch_op;
>
> #include <xen/elfstructs.h>
> #include <xen/errno.h> /* For -ENOSYS or -EOVERFLOW */
> +
> +#include <public/sysctl.h> /* For LIVEPATCH_OPAQUE_SIZE */
> +
> #ifdef CONFIG_LIVEPATCH
>
> /*
> @@ -51,6 +54,12 @@ struct livepatch_symbol {
> bool_t new_symbol;
> };
>
> +struct livepatch_fstate {
> + unsigned int patch_offset;
> + enum livepatch_func_state applied;
> + uint8_t opaque[LIVEPATCH_OPAQUE_SIZE];
... this use a separate, new (and internal only) constant? Thus also
elimiating the need to include public/sysctl.h above?
Jan
|
