[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: Remaining violations of MISRA Rule 7.4
I've just rebased and pushed the residual from the past work (although Imissed the ARM EFI fix.) https://xenbits.xen.org/gitweb/?p=people/andrewcoop/xen.git;a=commitdiff;h=0f06bab762f5201f3e00aaaee704c3c01f516b51 https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/1065699873 I'm going to make a firm request that we fix this by activating-Wwrite-strings Xen wide, because that's by far and away the best way tostop regressions creeping back in.In start_xen(), basically whatever goes. All that's doing is processingof one command line into another, and your version looks a bit neater than mine. The name.s cases (it's duplicated in x86 and ARM) are more tricky. The compiler warning can be silenced by swapping name.s for name.cs but Ihave no idea whether Eclair can see through that piece of blatent lying.~Andrew Just to avoid any misunderstanding: do you have the intention of evaluating and then perhaps integrate the fixes that at the moment block the introduction of -Wwrite-strings and then respin your patch, or should I do something specifically? -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |