[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/traps: More use of nocall
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 21 Nov 2023 09:52:21 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/V/om9C876igB3pduHGj2H1MKCzA5wuXePJYAXj22CI=; b=ni82ubaXmug/Hir+wxEK2EVfVDAH8rsJltz4KRRNHnftTMr3ZN0qv16B6gZyO3n6si8SKl64SHjwKZSPQzWAQWVxLc/rY21YKFFWHhN5DVHTJ6lo3lH4Zwl+f50chq88nTmjc5zBSEkhyGPPipFrYKDAzk+QGE+jC+plFHVZfDeobMp/l3X0/8mwwrdluX3MIss2efyl3MGUt/u1ecYevhahtNhOgNu4KStghOXvKB6ogpNU43EUIo9C6HsM3U/M3D85dqROVmw1xCStrV93EdEJmtJWYCsz/tbaKeIgdZMyDiCSK3JuFoEsPErSc9T7SBpkA642NoAO6hBD+BxorA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I9UDxEvcK+HXLFT84w5i0oqHl7vhDUXtCIGAtMOOKA/p2CXI+0pne4Q6U+Q2IR+ZXBTh5p3CnGgHZFyz3bfwMVvgln+bmGhj/WO+GId4bWGAUPeML+lz7nsrU93Fiuz3WSAz5rNBQRVpmPzc4uteGxFtJBT30R39mYU46jfqLZhB06Q3hoy0bq9D1V2Bc1raqEGh8r+D8HAnKyNAx6w9TCHTnbD4WX5ICgoTYMxWcCe5Ia8NhyBBLwBEeFxEcDGVYc7axE6svR/M7u7jhnkzLJRv+uZA21uSzT0hqd3rYcf4dlTVBvlTLzNxiGWJlpV4oJBPyp1dsiJpiO8K/qzEvA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 21 Nov 2023 08:52:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 20.11.2023 20:45, Andrew Cooper wrote:
> sysenter_eflags_saved() and int80_direct_trap() are now only used by a single
> translation unit. Move the declarations into the respective traps.c, renaming
> int80_direct_trap() to entry_int80() to match the style elsewhere.
>
> Annotate all 3 with nocall like all other entry paths.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Nevertheless I wonder if this wouldn't better be deferred until asmlinkage
has appeared in the code base, such that along with nocall that could be
added at the same time. (Even then it's not entirely clear to me whether
Misra is going to be happy with declarations not living in headers. But
imo limiting exposure trumps Misra's possible pickiness.)
Jan
|
