[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 06/14] xen/asm-generic: introduce generic header percpu.h
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 21 Nov 2023 16:56:46 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eBCj/EXm57kn1zsgTctsCCYf1FJwiCaUDCsegUb90x8=; b=h+Q74LQFUQT5lsZMZ0Aci2SiRbYBn+CGYATW7YhvQCl9Z1Wcdu/BiP6+OLx/iYc20MBHzCsZ2TTezw1oGlQrxHK3ua25CX9dqUwXn8gdwcIG4iGSZUCIvoLPgIBPe4B2M7SCiUBQsK9f1wEQQbamQswYy3lUv+7hdkwF3uqE4JZVaB2plTlQr33eAvPNUbS16XGKpeJmcigm2FWQlNqUAcB1pB/1wzlQXXViawYy0SJRsKHNQ0fDHfYX1stbtIVXxjetfP7L09L3xjmwxJh/Jypzy7btD/uBAGbVYAcDEqAhGgm6BrhR1GmnpFFqsmhPa3ieDQ0Lh0U7iEMR1+1pPw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i078C2MGPvcZBjKQPscFeQhSnVMjOfm/YgTDS/soFfpvEgOVNARoD70nlGoBCgYp5abVKHmSnC6HGprcsHjk0ogCXFHWjzYFT07ONyYZFuGftSBOCXm7NrxIdSd9IssOUsm2vNX1sj1uYdkkNo7T02fnu6w9jbhI7pPwMMeZJ89dV0MQnd0p1KSd8d8XGV+nWS7zkbNYKO7V0pAHYeJP1G6Bn7U2sN+h00ml/gJ+EMaNt5YzmIyp5S2BALC4qiez8HDpEd1wiDQVMveOR8kuJxdD1BYgdKqaW5O0Kjae6enwBOZN4PJ4JqedciZj0rfPV1V+cucZNAFajOOFqgfsFw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 21 Nov 2023 15:57:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.11.2023 13:24, Oleksii Kurochko wrote:
> --- a/xen/arch/ppc/include/asm/current.h
> +++ b/xen/arch/ppc/include/asm/current.h
> @@ -4,6 +4,8 @@
>
> #include <xen/percpu.h>
>
> +#include <asm/processor.h>
> +
> #ifndef __ASSEMBLY__
>
> struct vcpu;
> @@ -38,6 +40,10 @@ static inline struct cpu_info *get_cpu_info(void)
>
> #define guest_cpu_user_regs() (&get_cpu_info()->guest_cpu_user_regs)
>
> +#define smp_processor_id() 0 /* TODO: Fix this */
> +
> +#define get_per_cpu_offset() smp_processor_id()
This 2nd item can't be quite right either, so likely also wants a FIXME comment.
Shawn will have the ultimate say here anyway.
> --- a/xen/include/xen/percpu.h
> +++ b/xen/include/xen/percpu.h
> @@ -1,8 +1,6 @@
> #ifndef __XEN_PERCPU_H__
> #define __XEN_PERCPU_H__
>
> -#include <asm/percpu.h>
> -
> #define DECLARE_PER_CPU(type, name) \
> extern __typeof__(type) per_cpu__ ## name
>
> @@ -29,6 +27,8 @@
>
> #define get_per_cpu_var(var) (per_cpu__##var)
>
> +#include <asm/percpu.h>
> +
> /* Linux compatibility. */
> #define get_cpu_var(var) this_cpu(var)
> #define put_cpu_var(var)
While you explain the reason for this movement, it still feels a little
fragile to me.
Jan
|
