[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] xen/arm64: Move print_reg macro to asm/arm64/macros.h
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 21 Nov 2023 16:05:54 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j2uoBRXBnqR95i1/bOvWv7MTcVU7IQa7bBw6rm7ixrQ=; b=j/Rsorc+bHYTAP2qUmTkj7nNjxpAW7ifBmqxVnaL9H5g9IMEHfgEXXmfFH65PA9Q+rt/ZrGZpD2bzEYZHMQUDO8F4QjmFwEoBsAKLVVm6loxUuLum8KysETB5C2vSSTb5BWiCAKDYLslr8HKINW6/rTNAEaERgOVC0rvk86fGxoC5mQjSmJuRF1E9DUvMl35NouqKg97XLxWt4LNOB09l7fXQZV5EqK8k1QlqdAzk46cxokWzHdXpMJSEmnDikRvezMgb0gnGTTa/NmDtDFYfDt7fn2ovDsr9Lt3C6kK6clOp2f/q9g/TVJ+UtWY8IPE0uxlYX1isuALofMTSuRwGg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j2uoBRXBnqR95i1/bOvWv7MTcVU7IQa7bBw6rm7ixrQ=; b=mpIfDJ70kjjBxmCEV1VBo2A4Zcc29/z67BPwR9ZjVzaBjnR00lDf9Olw8VQwmEDnQ0lUsQw/mlmNhuBhyzj0bcwOc4yvZqYLQmubbAkKXz5+aDnmcEzLFBUyWW4FApViO3LBBQWT+vJIXZNpHLinNrvBtCcCOHr1nkl8l/CL82EJ05NIAjI/ZsSMKtB1Md53NcEGWNMr90o/d4g2p6Ylz2tCAFfoYJmSKPSer3sCnKOpC09UdFT5bN7LLHIVcqe41eU6Jrx9LRPRHIyyfaJzsBlcmt/jw8djrjU8wkQ1PAAWqQUKeIkeTyq/60H2GCFNkYumSwVYENiHm9Vw2ymnqA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=TmKTjeVytJRpZOl1WpU59BrTEuczTkpllgFuitqGuwuq/yw13/oBUh3TtQW4WpIKcwyM2MlDZJH4jFbe2bhrxHUxkdB44LlEu9WA/KTGe2l043sHMfvC7GP/pqcNqtf85KysRYdSwL2xGXNt3XX+11SC8y1KGym0LSq5WtOGS1R5f0kq2j8XZ8iTJRh6CIiB31ja7fO88WG4huRa6OiOu1pQZzemCdbQeBQayIMjTWIdiBOHpfGxz39t51jajYoKt3/S84XQWgZ7GdWZMWnsmSgaQPD2tlrNk2TGyyQCGaWWFKAlazgqS5F0k3UB7mSWS9DX8Tyj6me3M0coui6sWA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BYsq3t49tKgvjagNdvT5/2sCUB5JjCWNwszK5wSxSq7Z46HyvAr6ZtMqitjYAZXCexynGTM1fj3gWskwT0UDh9AoWJvUGjiQI8Mm2i9rlfkEJZQQeFOcsnwjazhqS04bqHoBmdlSu3dihJMF0UZAvV8PDvLKpHXSr3U1r+ABgXQ9lphDh7WgNGNWtCs742jXDGPJgnJBWP8/sYbcx6iI3p4aTCYQQrRQUYEUsDvFE0oKI7nd58vRajoTxGAE5j+dSkW8GHrd7LDfnAlNqInrlUR+Vf2AZF5Tb/fOVeD/L8TCxPLUv2dGvGxd7WoniPzcRH/ebfgeaC8hHdZlnazPsA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 21 Nov 2023 16:06:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHaHF+S9b0wSZeiakukBngLLnFSxrCE8GoA
- Thread-topic: [PATCH 2/3] xen/arm64: Move print_reg macro to asm/arm64/macros.h
> On 21 Nov 2023, at 09:45, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> Macro print_reg is used to print a value of a register passed as an
> argument. While today it is only used from within the common head.S,
> in the future we might want to make use of it from other files, just
> like PRINT(). It also serves as a great aid when debugging.
>
> Expose print_reg macro by moving it to asm/arm64/macros.h and:
> - rename putn to asm_putn to denote the usage from assembly only,
> - use ENTRY() for asm_putn to make it globally visible,
> - get rid of unneeded stubs for early_puts, init_uart and putn since
> the calls to them are already protected by #ifdef CONFIG_EARLY_PRINTK.
>
> This way the behavior will be consistent with what we already do on arm32.
>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
Hi Michal,
I’ve also tested on FVP
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
