[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/5] arm/efi: Simplify efi_arch_handle_cmdline()
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 21 Nov 2023 20:33:36 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S/o9OzXkc3QTL7NZ2EPElr5LfwbIjZamn9aUs9pNXPk=; b=MTNATq+Ju6GdSJhTaBr1UBjK+WGJqVBr7zTEKYYqfg0WuZGf49Y87gbNprEm9sXLGVBHw+B8clLDRPe3LEdsmdJcC2YYlQSJRdUdy6zuEOVAjB8O5xfpqGWJjCkgKzrLL7bE+SimugdG0NCCWDDnRZ89Wcj3Gvr0PFgjCng/nzfPTmf0BRNyKvgulmtpCu/U/jUmI9TfDfh4OfJx0rOdquMVIofLPcgOyHrs2NqkLpZNplQ+x2whiblQBwC8ySk+R3Fjgj8Z9xWe5/UML85E03Q7EWgB7qcTQu9vhgXGeh4Lzguv0wgQ3kt0r2kIJRUZKHFegYHE59bjIsoBIlaudw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S/o9OzXkc3QTL7NZ2EPElr5LfwbIjZamn9aUs9pNXPk=; b=UbDG0yIbKnvTtUyYT4Ho29UjEwR7Nr0ovI6RajAk3lIUKQ9WEa+eXBNTU79+FIthP0DtGBOTk10Fu4wvDOu1YwMTyjM+d+1Ic79XgfECxw4KFhlt9+shZOWOok6gJh2iCitJfBzJY8uoG90GcRm2dJaXe0dKGXYBKSe7rXRAUG+X4X5o7xsyCv9qzJO+6iZgIz84A0Fr7QJVMPiWBHkFDSS6Q6s8g5+MktNgxX7vl6KMRY8GlPMDNkDJrr8Wz6Vixvc2AT4YLRubXbel+M2C5taaPkfuLkeKhdngUc4nuzLjYFNwFqoqi+oN/3PTtMCksaZywCUyRqbEwUE8edwLkA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=bNvpE3p7q7tiBwjZKVK4HjqhYeI/44gh1x3txNMCmCGyu0rhnmubZyWOgacJXFzLV8OAoToMHIkU+fkLn24sGaevCQ+UR8dwNfZIzEMtjI5i79TzOg1Py7U4BhdiQ6iak990DO4hREveV3nnIl3R0J96N98mumRa1r/C3BC9mdS2gm0RU49dql9LI+vrfgXzDhFxrogf8a/v9cP23pg3mnQd6hGafAqrn4bj4+0vfcEOOis0/Cu86chY7LvHIyuUGKy1zPmReMsyxlKUb2j9cKe2So1q3iREOH71mzyp5U7tCoOCBit3gMVbbxvs4DxP3zq6CoSaldcTgUJ9c3ebbQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dXSWlxBjUa2vKPrVilrAaMNUsmsCIWVfv4jOCtFpopg72v+A0FiOSYxrxiOekuexfz/ohI0nNyxd8oQGDdaodXRdCPqforVikHXyIR2HgBQkO+T00U9sMi8qMiqPrY2wDMk4POIrttDfcSyTf1KX6I6pAJ3vrKGY9G4JHNx3gAljqqS18jECzULA5Bh2lULCURSwRR3oNaPO5fnNYBsDbuzctI3IoYcxvhk0upJ9TAq8/YfOsQ2GX79Mxzh4qkD90C8+u0RAs+6Rd4hFiJ8fIcAXxB4/S9H2cDYzVxNakwqrYHJMZ/bQg0uErMRR/uLOHOJ4F8FUVwCs6uBEEeFfoA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Roberto Bagnara <roberto.bagnara@xxxxxxxxxxx>, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- Delivery-date: Tue, 21 Nov 2023 20:34:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHaHLkYgzDzOjzraUK+7wQZW0TenrCFOoGA
- Thread-topic: [PATCH v2 4/5] arm/efi: Simplify efi_arch_handle_cmdline()
+ CC henry
> On 21 Nov 2023, at 20:15, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>
> -Wwrite-strings is unhappy with assigning "xen" to a mutable pointer, but this
> logic looks incorrect. It was inherited from the x86 side, where the logic
> was redundant and has now been removed.
>
> In the ARM case it inserts the image name into "xen,xen-bootargs" and there is
> no logic at all to strip this before parsing it as the command line.
>
> The absence of any logic to strip an image name suggests that it shouldn't
> exist there, or having a Xen image named e.g. "hmp-unsafe" in the filesystem
> is going to lead to some unexpected behaviour on boot.
>
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> CC: Julien Grall <julien@xxxxxxx>
> CC: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
> CC: Bertrand Marquis <bertrand.marquis@xxxxxxx>
> CC: Roberto Bagnara <roberto.bagnara@xxxxxxxxxxx>
> CC: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
>
> v2:
> * New.
>
> I'm afraid that all of this reasoning is based on reading the source code. I
> don't have any way to try this out in a real ARM UEFI environment.
I will test this one tomorrow on an arm board
|
