[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] tools/python: add .gitignore file


  • To: Juergen Gross <jgross@xxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 22 Nov 2023 10:59:25 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d6Z/4WQCzv6H16+oNybb/zJlsDnm4vSATftKXSdUvy4=; b=ZZhlSg8bLvzdrnjn3LaVmteUE1WqRqvUo3w8B8gMalHxlEMxcDuDUmXFqdLD8e6znNwqk9TfFTbekN+ZdalIQ2Ni1vBe0b1qx+KY2M0XwLp6OqJ+62Gl/OS4Olt544PL1WsorNiViVNrvqRCj7iAhymJjeMHLKictoDrJQi2zYqWBSR9fpZjHMqtyUP8VTY/gsKpT3ScE990QBtbi0zLAKzPqMHLn9C1aJHBGRIVkSZl6kxKhLTR5Dt7TtpX8ii5BlgrKDYG9hur8sxzWa9O0l7ni7SiIv3cJq78dx2kjVTkT3reB+4s2Lel+ikrWitIn0gB0VBdp10R9xh8IgaQiw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iltpC+tILz/cSvgE//TSB/j3yZxlVfiM3WzeILENih55ARB80ekn7XN+Tz3P33N7O9Kq6bhWx/Lr4uFXJGPRrLi/ef3fOvtoqS/hyue/FmKynqB/3XLd+jIotN9jqijoIMz1PQVX8CUA+tQkHwhnUFxQM+4+did7xhJ3EZzdr6s4sPZyZ/+cEQnl6FZ4n6bqbKOC7tTyv8sOJTcObgu2G3D+kasnKe5NaiwyWPkOtVWCJp+wJ3ibG8DkPFiMCwhXM+JCcoVpj5FUPjg1UbO1J3sSRg20757PCvk00bJU/9YmB7gWsLPp/o2MbWAXn2UzPOeC/4AR9USukj2o5l5DlA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 22 Nov 2023 10:00:04 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 22.11.2023 10:53, Juergen Gross wrote:
> On 22.11.23 10:21, Jan Beulich wrote:
>> On 22.11.2023 09:57, Juergen Gross wrote:
>>> On 22.11.23 09:39, Jan Beulich wrote:
>>>> On 22.11.2023 09:31, Juergen Gross wrote:
>>>>> --- /dev/null
>>>>> +++ b/tools/python/.gitignore
>>>>> @@ -0,0 +1,4 @@
>>>>> +build/*
>>>>
>>>> Are this and just build/ actually equivalent? Looking at our top-level
>>>> .gitignore, I see e.g. extras/ and install/*, which I would expect want
>>>> both treating the same? The form with a wildcard, to me at least,
>>>> doesn't obviously include the directory itself ...
>>>
>>> The .gitignore specification [1] suggests that we should use build/ (same 
>>> for
>>> the new entry), as otherwise entries in subdirectories would not match.
>>
>> The description there of what a trailing slash means isn't really clear.
> 
> "If there is a separator at the end of the pattern then the pattern will only
> match directories, otherwise the pattern can match both files and 
> directories."
> 
> "The pattern foo/ will match a directory foo and paths underneath it, but 
> will 
> not match a regular file or a symbolic link foo"

But this is all about entries named "foo". Nothing is said about whether
foo/ also includes foo/bar.c.

>> Nothing is said about anything underneath the specified directory. Also
>> nothing is said about what a trailing /* means towards the named directory.
> 
> "The pattern foo/*, matches foo/test.json (a regular file), foo/bar (a 
> directory), but it does not match foo/bar/hello.c (a regular file), as the 
> asterisk in the pattern does not match bar/hello.c which has a slash in it."

Similarly here - nothing is said about foo itself. Yet from us successfully
using foo/* entries I derive that they actually cover foo as well, no matter
whether that's actually sensible.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.