[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] x86/mm: Fix up bad bool conversion in ept_set_entry()
- To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 22 Nov 2023 10:28:08 +0000
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 22 Nov 2023 10:28:42 +0000
- Ironport-data: A9a23:JAIrs64rTAfjeZYbK4MhMgxRtHHHchMFZxGqfqrLsTDasY5as4F+v mAYCGiObqnbN2r2eth1aNmzo0gOsZOBxoMwSFM+r3s8Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRG/ykTraCY3gtLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9lU34JwehBtC5gZlPKkR5geH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m9 6ICBWBTaxy/mbi034OqeLkvheMfI5y+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmRJUIXUrsUIMtWcOOAr3/zaTBH7nmSorI6+TP7xw1tyrn9dtHSf7RmQO0MxBnE9 juWoTmR7hcyMoCR42e5y3SWi8T/gXriRdMeSZuz+as/6LGU7jNKU0BHPbehmtGph0j7V99BJ kg8/is1sbN05EGtVsP6XRCzvDiDpBF0c/h6HvA+6QqN4rHJ+AvfDW8BJhZebPQ2uclwQiYlv mJlhPuwW2Yp6ufMDyvAp/HL9VteJBT5M0cAOzUpHVUA7+X9+oMsvwP9HpVgN5K624id9S7L/ 9yakMQvr+xM1ZZWh//mogCvvt66mnTeoucICuTrsoGNtFoRiHaNPdDA1LQixa8owHylZleAp mMYvMOV8foDC5qA/ATUH71VQeDwuavVaWSA6bKKI3XH3271k5JEVdkAiAyS2W8zappUEdMXS BO7VfxtCG97YyLxMP4fj3OZAMU216nwfekJpdiNBueilqNZLVfdlAk3PB744owYuBR0+U3JE cvBIJnE4LdzIfgP8QdasM9HieBynHtjmDOLLX05pjz+uYejiLeuYe9tGDOzgioRtctofC29H w5jCva3
- Ironport-hdrordr: A9a23:bvnJ96ApX1nMLdHlHemg55DYdb4zR+YMi2TC1yhKJyC9Ffbo8P xG/c5rsSMc5wxwZJhNo7y90cq7MBbhHPxOkOos1N6ZNWGM0gaVxelZnO3fKlbbehEWmNQz6U 4ZSdkdNOHN
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
This accidentally turned a 1 into false.
Noticed by Coverity.
Reported-by: Jan Beulich <JBeulich@xxxxxxxx>
Fixes: de577618c285 ("x86/treewide: Switch bool_t to bool")
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
CC: Jan Beulich <JBeulich@xxxxxxxx>
CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
CC: Wei Liu <wl@xxxxxxx>
---
xen/arch/x86/mm/p2m-ept.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/mm/p2m-ept.c b/xen/arch/x86/mm/p2m-ept.c
index 227bdf7c2433..f83610cb8cd8 100644
--- a/xen/arch/x86/mm/p2m-ept.c
+++ b/xen/arch/x86/mm/p2m-ept.c
@@ -803,7 +803,7 @@ ept_set_entry(struct p2m_domain *p2m, gfn_t gfn_, mfn_t mfn,
bool need_modify_vtd_table = true;
bool vtd_pte_present = false;
unsigned int iommu_flags = p2m_get_iommu_flags(p2mt, p2ma, mfn);
- bool needs_sync = false;
+ bool needs_sync = true;
ept_entry_t old_entry = { .epte = 0 };
ept_entry_t new_entry = { .epte = 0 };
struct ept_data *ept = &p2m->ept;
base-commit: 10081c2dc571775b538bb00982606a39832ad7e3
--
2.30.2
|
