Re: [PATCH v2 4/5] arm/efi: Simplify efi_arch_handle_cmdline()

[Julien Grall <julien@xxxxxxx>]

Hi Andrew,

On 21/11/2023 20:15, Andrew Cooper wrote:
> -Wwrite-strings is unhappy with assigning "xen" to a mutable pointer, but this
> logic looks incorrect.  It was inherited from the x86 side, where the logic
> was redundant and has now been removed.
>
> In the ARM case it inserts the image name into "xen,xen-bootargs" and there is
> no logic at all to strip this before parsing it as the command line.
>
> The absence of any logic to strip an image name suggests that it shouldn't
> exist there, or having a Xen image named e.g. "hmp-unsafe" in the filesystem
> is going to lead to some unexpected behaviour on boot.
I have noticed this behavior a few years ago but never really looked why 
 we added the name. So thanks for looking at it.
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall