[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 4/5] xen/arm: Move static memory build code in separate modules


  • To: Luca Fancellu <luca.fancellu@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Michal Orzel <michal.orzel@xxxxxxx>
  • Date: Fri, 24 Nov 2023 11:48:29 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WtE0gSxJw4o2GFpTOi5DoZtQJ/3WJX48J0z3EA7jhKY=; b=S+sKHn+geK6NE+XkoG7nB99Rjlu2Lz+ARPQH8g9+Ij6JyuLaURAKOuS8rm8PcTMyTB9Zl6ru8YAF0xUUrc4hgpV8NfuZD/yGKPhyz5v4oUFFqNSPoW73IMOji0K43DRoVm3yb+qMR9IfAkNPVjQQRZEr5BnrHgVSuWsRJMnBT+H0SE/ql2RLZXfuoauohv6MuLndispqpmZpPwf4KZXoV/W6dP3kXT2y2IsRJsGhUrxN3VxRZY5FFtbApKpiqYGdG+JLQisqOB89bLOIVYhBM4x9lJ5+Z90ZAil7YNTe8y9Lo3Wq954reQfW6BCcT32K9eUdNe2vDbVCaIGxqA/oCQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q2OeljKCq8p90aklX4NJgeJu0Hj0PrTYgnzzPHa7CCzk4U5fEP+4mgIkzxW6zbOmF4kHXx6cABslX7UJyp206TQPFs+FGKGouh05yTVZ+nswg7S3Pep9ru2UJiZdZdY09VaiMIKT33pwFea9u/S/EClQFicHHICTRWaf++cVynzVZC8H9V7PcnKAbZ5e80ZF2AxPYVC9V6MZ+piWLWIFBj7CJChVRN6p0if0fNCWmooiJLy5RR56r1izhJeoxvMzZ9m9F+22cjcn9LBHFqaDIz3t/A1diS+Fc8g6Z5dU4Frd265zO+1U2EbMUVwM67osdUwX+cIdBbfqNLZ+nOfYaA==
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Delivery-date: Fri, 24 Nov 2023 10:48:40 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi Luca,

+ CC others

On 24/11/2023 10:48, Luca Fancellu wrote:
> 
> 
> Move static memory and static shared memory code in separate modules
> so that they are included only when the corresponding feature is
> enabled, doing that we modularise the features and we remove some
> ifdefs from the code to improve readability.
> 
> Move process_shm_node function from bootfdt module and make it
> externally visible.
> 
> A static inline helper called process_shm_chosen is introduced, it
> will call the process_shm function for the '/chosen' node, and will
> be used by the function construct_dom0 instead of using directly
> process_shm, allowing some #ifdef to be removed.
> 
> No functional changes are intended.
> 
> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>

~Michal



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.