Re: Clang-format configuration discussion - pt 2

[George Dunlap <george.dunlap@xxxxxxxxx>]

On Thu, Nov 23, 2023 at 2:48 PM Luca Fancellu <Luca.Fancellu@xxxxxxx> wrote:
> AlignConsecutiveAssignments: None
>
> ---
> This one is disabled because of feedbacks from Stefano and Alejandro about 
> some weird behaviour on our
> codebase.
>
> This one could be phased along this line: “Consecutive assignments don't need 
> to be aligned.”, the issue is
> that in this way it seems that it’s optional, but clang-format is going to 
> remove the alignment anyway for
> assignment that are consecutive and aligned.

It's hard to agree on this one without seeing some of the examples of
what it does, some examples of the "weird behavior" Stefano &
Allejandro found, and some examples of places where it's going to
remove the alignment.

I had tried to apply your series before and didn't get very far with
it for some reason ISTR.  One way to see the effect of individual
features would be:

1. Make a branch with one big patch applying clang-format for a given style

2. Change just one style line, re-run clang format, and create a new
patch from that

Then it would be easy to see the difference between the two.  It might
actually be easier for individual reviewers to do that on their own
trees, rather than to ask you to try to generate and post such patches
somewhere.

 -George