[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 09/14] xen/asm-generic: introduce generic header altp2m.h


  • To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Michal Orzel <michal.orzel@xxxxxxx>
  • Date: Fri, 24 Nov 2023 14:00:28 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i7SFUSNGiUIjnozlsTsX9Le9wc3ZYVthP5VFGjMhrPY=; b=ZjhfiXdgLbLZlF+yNeSwAF0pE50WDnWfCz01biUPvmPJmn/7jOoHfUcCbeu20Jg38j01DDdmoML9MYS/Z77eo8A4hzyZr1RSnXb/Ep/qSTjF9MZzaQj07viM40sEq0AWczjiDCwncvVpzuUNYWiW3pBojmrTIY3J7LUrFYQt3ctpbFQOKLmMq15PdlSfyeou66Qkgfc5hosIX9RNl9NsXRjkLdm2aRg7d7L9jynHACHZuI3slX/pOWvJbDEs+OqyTR9d9rd0Uaqf3q4dMfezmVFXXrG6fujzyeL9gullHyt5rjHVfhtl2/b0UrlHyYx5q11sXJst5DUSJRtmhrdMYg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dmD1/Fc5aZ1LULXO3t6niazlgkgWU4q++KQzDauPUMJBZqmrOB+oIcGlc7TNZUG3axz9kJwWsX++dsTcvtZBE6qKLFy8wLI5lTyJxSI57w4/UrzCWr964Q4CRmbrl5oF7jACX5ehN/49706yfPhCXJnTX9NPtfPQmQ6u6FhDYQigpCEoD6F1OZ1vgTqENu5wG1sJ0E/Xl2OGzoZopvhlSV2Vot6+2FQqn9xQSjGAdEngNOnzgcR+6YiVUEcxsWbWEcuoWGKWyh3R7C7WbF+wK8U1xGErVWPrOmML63N9wQAlqfhfw3mTU6Yjrs4/1ijAXdxHq0zKQ+LGuWC0nYGQ3A==
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 24 Nov 2023 13:00:46 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi,

On 17/11/2023 13:24, Oleksii Kurochko wrote:
> 
> 
> <asm/alt2pm.h> is common between archs so it is moved to
> asm-generic.
> 
> Arm and PPC were switched to asm-generic version of altp2m.h.
> 
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> ---
> Changes in V3:
>  - Drop Arm and PPC's altp2m.h
>  - Update the commit message.
> ---
> Changes in V2:
>         - change uint16_t to unsigned int in declaration of altp2m_vcpu_idx
>         - update the commit message
> ---
>  xen/arch/arm/include/asm/Makefile |  1 +
>  xen/arch/arm/include/asm/altp2m.h | 39 -------------------------------
>  xen/arch/ppc/include/asm/Makefile |  1 +
>  xen/arch/ppc/include/asm/altp2m.h | 25 --------------------
>  xen/include/asm-generic/altp2m.h  | 34 +++++++++++++++++++++++++++
>  5 files changed, 36 insertions(+), 64 deletions(-)
>  delete mode 100644 xen/arch/arm/include/asm/altp2m.h
>  delete mode 100644 xen/arch/ppc/include/asm/altp2m.h
>  create mode 100644 xen/include/asm-generic/altp2m.h
> 
> diff --git a/xen/arch/arm/include/asm/Makefile 
> b/xen/arch/arm/include/asm/Makefile
> index 36d95d6310..8221429c2c 100644
> --- a/xen/arch/arm/include/asm/Makefile
> +++ b/xen/arch/arm/include/asm/Makefile
> @@ -1,4 +1,5 @@
>  # SPDX-License-Identifier: GPL-2.0-only
> +generic-y += altp2m.h
>  generic-y += hardirq.h
>  generic-y += iocap.h
>  generic-y += paging.h
> diff --git a/xen/arch/arm/include/asm/altp2m.h 
> b/xen/arch/arm/include/asm/altp2m.h
> deleted file mode 100644
> index df50cb2f09..0000000000
> --- a/xen/arch/arm/include/asm/altp2m.h
> +++ /dev/null
> @@ -1,39 +0,0 @@
> -/*
> - * Alternate p2m
> - *
> - * Copyright (c) 2014, Intel Corporation.
Shouldn't this copyright be moved to generic header as well?

Apart from that:
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>

~Michal



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.