[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/6] x86/msi: passthrough all MSI-X vector ctrl writes to device model
- To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 27 Nov 2023 17:18:14 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nk0MbnXXzvWD5Lzxn3+PntMR9YtRJ90kYdVw6zNPDoo=; b=SczyEJ0E0RRxXWvKVUT5zQui3/o1CMgKz7IfCQhjiKmgGCKWkEYmdF7b55Roe1MlwmqYP5Y8dagaqwvGxMmzWM806K4AQlwMqcsv6SQGLvjM/j7Ie8L0xg4Ju93k3skGHkwAM/gn0DY50DWYDggZwPraFP2XEVRpKkr37fVh8DFBQFRPXoN6ozvzZWBO5CA9baMkXdoK6TWOKabGRB+o0YNSaVq3yc+yDMBq0+sJtTS70/hyv/K/Q9W2DGGCzvMwCKFL8udR2N7wGxwwsFJBpXov3hNUjpFZnShieQkC0W8Yavn6+Y5qokYn9tuLslZBANQg7ievqTPPTvrBKALSLw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XRbQvc6twqf02huIJ0vUhPzwUt+PFAPMDlXjbknESrw+1ZwYGJ4f5uApxMtpAAlNt6ch1bF3kE63XVCUYWP52zpmkTFeHe6xmv0kxO1VcwAHKD1DFKm9ZEIS8hPxaCH7o/jKJN0oVf2Y1hN/6rmwBb6xlGd8s9XLgRqzOX1z4i/62Bh82JGtdPhkddZby6WmsCeXgXUhlz9QNfWcEOfoFR79PL6pHZFeM/LNY56iz5kteAm6l7qGs8+43uHCMWav0XeXzhW3uWaIevTMzvu2y1dK2I8eRwLM0+p+HXK3sgXr6IqkHhewOGQojYZec6mrbm9TEanJBZu+/8/5KiOOBA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 27 Nov 2023 16:18:21 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.11.2023 02:47, Marek Marczykowski-Górecki wrote:
> @@ -357,7 +356,17 @@ static int cf_check _msixtbl_write(
> const struct hvm_io_handler *handler, uint64_t address, uint32_t len,
> uint64_t val)
> {
> - return msixtbl_write(current, address, len, val);
> + /* ignore invalid length or unaligned writes */
Nit: Style (capital first letter).
> + if ( len != 4 && len != 8 || !IS_ALIGNED(address, len) )
Please parenthesize the && as an operand of ||.
> --- a/xen/common/kernel.c
> +++ b/xen/common/kernel.c
> @@ -642,6 +642,7 @@ long do_xen_version(int cmd, XEN_GUEST_HANDLE_PARAM(void)
> arg)
> fi.submap |= (1U << XENFEAT_direct_mapped);
> else
> fi.submap |= (1U << XENFEAT_not_direct_mapped);
> + fi.submap |= (1U << XENFEAT_dm_msix_all_writes);
This probably wants to move up into the x86-only section?
Jan
|
