Xen project Mailing List

[xen-unstable-smoke test] 183874: trouble: blocked/broken

From: osstest service owner <osstest-admin@xxxxxxxxxxxxxx>

Date: Tue, 28 Nov 2023 02:25:04 +0000

Delivery-date: Tue, 28 Nov 2023 02:25:22 +0000

List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

flight 183874 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183874/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 <job status> broken build-arm64-xsm <job status> broken build-armhf <job status> broken build-arm64-xsm 4 host-install(4) broken REGR. vs. 183851 build-amd64 4 host-install(4) broken REGR. vs. 183851 build-armhf 4 host-install(4) broken REGR. vs. 183851 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a version targeted for testing: xen 72d51813d631fe27d37736b7a55eeec08f246983 baseline version: xen 80c153c48b255bae61948827241c26671207cf4e Last test of basis 183851 2023-11-24 09:03:53 Z 3 days Failing since 183871 2023-11-27 14:00:26 Z 0 days 2 attempts Testing same since 183874 2023-11-27 19:00:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Federico Serafini <federico.serafini@xxxxxxxxxxx> Frediano Ziglio <frediano.ziglio@xxxxxxxxx> Jan Beulich <jbeulich@xxxxxxxx> Maria Celeste Cesario <maria.celeste.cesario@xxxxxxxxxxx> Maria Celeste Cesario <maria.celeste.cesario@xxxxxxxxxxx> Roger Pau Monné <roger.pau@xxxxxxxxxx> Simone Ballarin <simone.ballarin@xxxxxxxxxxx> Simone Ballarin <simone.ballarin@xxxxxxxxxxx> Tamas K Lengyel <tamas@xxxxxxxxxxxxx> jobs: build-arm64-xsm broken build-amd64 broken build-armhf broken build-amd64-libvirt blocked test-armhf-armhf-xl blocked test-arm64-arm64-xl-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-amd64 broken broken-job build-arm64-xsm broken broken-job build-armhf broken broken-step build-arm64-xsm host-install(4) broken-step build-amd64 host-install(4) broken-step build-armhf host-install(4) Not pushing. ------------------------------------------------------------ commit 72d51813d631fe27d37736b7a55eeec08f246983 Author: Jan Beulich <jbeulich@xxxxxxxx> Date: Mon Nov 27 15:18:48 2023 +0100 x86: amend cpu_has_xen_{ibt,shstk} ... to evaluate to false at compile-time when the respective Kconfig control is off, thus allowing the compiler to eliminate then-dead code. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> commit 17754972fa98bff2dfdec09b8094f54530bafcb8 Author: Maria Celeste Cesario <maria.celeste.cesario@xxxxxxxxxxx> Date: Mon Nov 27 15:17:56 2023 +0100 x86/atomic: address violations of MISRA C:2012 Rule 11.8 Edit casts that unnecessarily remove const qualifiers to comply with Rule 11.8. The type of the provided pointer may be const qualified. No functional change. Signed-off-by: Maria Celeste Cesario <maria.celeste.cesario@xxxxxxxxxxx> Signed-off-by: Simone Ballarin <simone.ballarin@xxxxxxxxxxx> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> commit fc63c0ebefe7e9d166b07971273c1de62428eb18 Author: Maria Celeste Cesario <maria.celeste.cesario@xxxxxxxxxxx> Date: Mon Nov 27 15:17:32 2023 +0100 AMD/IOMMU: address violations of MISRA C:2012 Rule 11.8 Drop an unnecessary cast discarding a const qualifier, to comply with Rule 11.8. The type of the formal parameter ivhd_block is const qualified. No functional change. Signed-off-by: Maria Celeste Cesario <maria.celeste.cesario@xxxxxxxxxxx> Signed-off-by: Simone Ballarin <simone.ballarin@xxxxxxxxxxx> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> commit fe26cb2dd20fa864deb05e4b278bc9993ba120e6 Author: Maria Celeste Cesario <maria.celeste.cesario@xxxxxxxxxxx> Date: Mon Nov 27 15:17:07 2023 +0100 x86/boot/reloc: address violations of MISRA C:2012 Rule 11.8 Add missing const qualifier in casting to comply with Rule 11.8. Argument tag is typically const qualified. No functional change. Signed-off-by: Maria Celeste Cesario <maria.celeste.cesario@xxxxxxxxxxx> Signed-off-by: Simone Ballarin <simone.ballarin@xxxxxxxxxxx> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> commit 09c2fe438da1dfc83f70d921b52240bea576615f Author: Maria Celeste Cesario <maria.celeste.cesario@xxxxxxxxxxx> Date: Mon Nov 27 15:16:43 2023 +0100 x86/platform_hypercall: address violations of MISRA C:2012 Rule 11.8 Add const qualifier in cast that unnecessarily removes it to comply with Rule 11.8. The variable info is declared with a const qualified type. No functional change. Signed-off-by: Maria Celeste Cesario <maria.celeste.cesario@xxxxxxxxxxx> Signed-off-by: Simone Ballarin <simone.ballarin@xxxxxxxxxxx> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> commit 82182ad7b46e0f7a3856bb12c7a9bf2e2a4570bc Author: Roger Pau Monné <roger.pau@xxxxxxxxxx> Date: Mon Nov 27 15:16:01 2023 +0100 livepatch: do not use .livepatch.funcs section to store internal state Currently the livepatch logic inside of Xen will use fields of struct livepatch_func in order to cache internal state of patched functions. Note this is a field that is part of the payload, and is loaded as an ELF section (.livepatch.funcs), taking into account the SHF_* flags in the section header. The flags for the .livepatch.funcs section, as set by livepatch-build-tools, are SHF_ALLOC, which leads to its contents (the array of livepatch_func structures) being placed in read-only memory: Section Headers: [Nr] Name Type Address Offset Size EntSize Flags Link Info Align [...] [ 4] .livepatch.funcs PROGBITS 0000000000000000 00000080 0000000000000068 0000000000000000 A 0 0 8 This previously went unnoticed, as all writes to the fields of livepatch_func happen in the critical region that had WP disabled in CR0. After 8676092a0f16 however WP is no longer toggled in CR0 for patch application, and only the hypervisor .text mappings are made write-accessible. That leads to the following page fault when attempting to apply a livepatch: ----[ Xen-4.19-unstable x86_64 debug=y Tainted: C ]---- CPU: 4 RIP: e008:[<ffff82d040221e81>] common/livepatch.c#apply_payload+0x45/0x1e1 [...] Xen call trace: [<ffff82d040221e81>] R common/livepatch.c#apply_payload+0x45/0x1e1 [<ffff82d0402235b2>] F check_for_livepatch_work+0x385/0xaa5 [<ffff82d04032508f>] F arch/x86/domain.c#idle_loop+0x92/0xee Pagetable walk from ffff82d040625079: L4[0x105] = 000000008c6c9063 ffffffffffffffff L3[0x141] = 000000008c6c6063 ffffffffffffffff L2[0x003] = 000000086a1e7063 ffffffffffffffff L1[0x025] = 800000086ca5d121 ffffffffffffffff **************************************** Panic on CPU 4: FATAL PAGE FAULT [error_code=0003] Faulting linear address: ffff82d040625079 **************************************** Fix this by moving the internal Xen function patching state out of livepatch_func into an area not allocated as part of the ELF payload. While there also constify the array of livepatch_func structures in order to prevent further surprises. Note there's still one field (old_addr) that gets set during livepatch load. I consider this fine since the field is read-only after load, and at the point the field gets set the underlying mapping hasn't been made read-only yet. Fixes: 8676092a0f16 ('x86/livepatch: Fix livepatch application when CET is active') Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx> Reviewed-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx> commit 46f2e2c3bcd5b17dae0fd1e45ed8619d6c047b55 Author: Federico Serafini <federico.serafini@xxxxxxxxxxx> Date: Mon Nov 27 15:15:09 2023 +0100 xen/mm: address violations of MISRA C:2012 Rules 8.2 and 8.3 Add missing parameter names and uniform the interfaces of modify_xen_mappings() and modify_xen_mappings_lite(). No functional change. Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx> Acked-by: Jan Beulich <jbeulich@xxxxxxxx> commit b82b867a6694368b9a74ed00397b2393d129a24d Author: Federico Serafini <federico.serafini@xxxxxxxxxxx> Date: Mon Nov 27 15:14:00 2023 +0100 x86/mm: preparation work to uniform modify_xen_mappings* interfaces The objective is to use parameter name "nf" to denote "new flags" in all the modify_xen_mappings* functions. Since modify_xen_mappings_lite() is currently using "nf" as identifier for a local variable, bad things could happen if new uses of such variable are committed while a renaming patch is waiting for the approval. To avoid such danger, as first thing rename the local variable from "nf" to "flags". No functional change. Suggested-by: Jan Beulich <jbeulich@xxxxxxxx> Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx> Acked-by: Jan Beulich <jbeulich@xxxxxxxx> commit fbcec32d6d3ea0ac329301925b317478316209ed Author: Frediano Ziglio <frediano.ziglio@xxxxxxxxx> Date: Wed Nov 22 16:39:55 2023 +0000 x86/mem_sharing: Release domain if we are not able to enable memory sharing In case it's not possible to enable memory sharing (mem_sharing_control fails) we just return the error code without releasing the domain acquired some lines above by rcu_lock_live_remote_domain_by_id(). Fixes: 72f8d45d69b8 ("x86/mem_sharing: enable mem_sharing on first memop") Signed-off-by: Frediano Ziglio <frediano.ziglio@xxxxxxxxx> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Acked-by: Tamas K Lengyel <tamas@xxxxxxxxxxxxx> commit b9eeb1992676ec83cee285b97fee94d03eaa9836 Author: Frediano Ziglio <frediano.ziglio@xxxxxxxxx> Date: Wed Nov 22 16:26:20 2023 +0000 x86/mem_sharing: Fix typo in comment ambigious -> ambiguous Signed-off-by: Frediano Ziglio <frediano.ziglio@xxxxxxxxx> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Acked-by: Tamas K Lengyel <tamas@xxxxxxxxxxxxx> (qemu changes not included)

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.