[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ubsan: Introduce CONFIG_UBSAN_FATAL to panic on UBSAN failure
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Tue, 28 Nov 2023 18:18:03 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W2g4BE85qk8wyCCP7jMD9iYWdmpV4+e9Gw7pD0pLouI=; b=Q1kN8yKq1D7WcwgD9klWkv3sabDhSMxlgB+qaX5+pgIztMpLSt3uF+dykMrFaIAdOz0DwD+4DyIVr7U5LKWH2jgVmShwCMJOCPF3RuOa+cvzZ1ee0c1VmPdGRngQGdqJldgc1y5ec9emW0GUVFIoJYu1yfX8wEJazvo3afm0Ro4mo/S5Y6zeAIN+ZORHsb93R44izounmCgvd3+6PrWZk+EuARNXaV8/e9A0a6DRaJHyT6hXd/yNyumIUrNqVTWQFWnk3TYazGdLw3yrCMdPyEW3MzDqkubMxJKfjH528ncApJs3tTsF11oyXH4b+QK1QP2AvyaUXwlCANCWzHF8LQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DEfxfvSkI7Usb9ZFkvuDPE6N/QjFTbxYf04x5VI/V1UZLp3HIMvEeHUC3g0yIr/c06MgmOkLk8UPqqUUbg9jRUBplutIljruhevjuUWbVXNaACySKPHtOuqRLf4icSLKS5u6WILcEm8XJdIYV3GYmTn7tFcKoUWo7SeaE1s/AEZJUDsc+qhkXbJCD2jkJkhhXo+6DnDapJOUvgHSnU3gZET8YaZEY7tmINEeTrnyFm3FCsqnu3PhU1wMuikZ8WkuVzGkLya2W/4bHTRsIfIcNJqVAYnQgAYXeGE9W0gWtmxjY6JSy7UV777ns45q4Pj5qmy4aovrufIXbeEtA/ZOfw==
- Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 28 Nov 2023 17:18:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28/11/2023 18:15, Andrew Cooper wrote:
>
>
> On 27/11/2023 2:41 pm, Michal Orzel wrote:
>> diff --git a/xen/common/ubsan/ubsan.c b/xen/common/ubsan/ubsan.c
>> index a3a80fa99eec..dd5ee0013648 100644
>> --- a/xen/common/ubsan/ubsan.c
>> +++ b/xen/common/ubsan/ubsan.c
>> @@ -174,6 +174,10 @@ static void ubsan_epilogue(unsigned long *flags)
>> "========================================\n");
>> spin_unlock_irqrestore(&report_lock, *flags);
>> current->in_ubsan--;
>> +
>> +#ifdef CONFIG_UBSAN_FATAL
>> + panic("UBSAN failure detected\n");
>> +#endif
>
> if ( IS_ENABLED(CONFIG_UBSAN_FATAL) )
> panic("UBSAN failure detected\n");
>
> please. Happy to fix on commit.
Sounds good to me, thanks.
~Michal
|
