[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v12 24/37] x86/idtentry: Incorporate definitions/declarations of the FRED entries
- To: Borislav Petkov <bp@xxxxxxxxx>
- From: "Li, Xin3" <xin3.li@xxxxxxxxx>
- Date: Tue, 28 Nov 2023 18:39:01 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rX2CeJgIYJbGV+oh0r4hEsDAougQ3cxnrsEAgRifYew=; b=lVZUZCrtMlwfvLDHko4O6WKZ30m2o4/rDInVJ4mOEZ6FUQjJVKRqeW7wZIOW0NvxyFPEdjyCz147PwYK6OjEHnO1mI2uFQrh2JQXEZAUo2gsz/NGuFlPogUzVSBe0YAumNyxK8eiXAyUwLDFyuVXkQeWQ6rW7LsKEKziZneslsp4WmSOX78KLZyKo7m4AnB7Lu/Fkine27Mo95LNhNa1wTACmXjxPvDYAeAqvTr5A+cA9C58QMKy6FEJvoF9COuhEdO4jaZ8bzEx5Qjy0j/LFGn66IhfcVcAb3sfAxC4Nq5XNpuBGJwlAjhOsZxVnx90cIGb8CbvBlb6h0Bxs9e+QA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A1EqYyZui79ew1E9p6XpzjS9PwzOOvoyDRglp21l/9SWIe+wiijb5m6n8SWWpay5Sflupxj1lrDH/SLbEcojBuuwJTk5bJ9Ua9Wh9Cp7adF9ryZ5lQX1igus6Fg7hw8gyt9bT7KFsBORYM6Sd9Db+Or7uxU6LW7HDH76+2VwyrYhD22NE77H/+gCtXLe1vuLzMY3gj5URuVcsM2yACcIV9qin7E4Rx/MJj4qfTY9X+E3mlDUqSOXNfrXzW1A2DObs9zIDdcq7/XHnSDqNLAObHh8e7LpqKw0T47bZDO2dMQR4ewmo3Lit/xM/gewslmppW3FAni1+CZkxsK07M91iA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com;
- Cc: "linux-doc@xxxxxxxxxxxxxxx" <linux-doc@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-edac@xxxxxxxxxxxxxxx" <linux-edac@xxxxxxxxxxxxxxx>, "linux-hyperv@xxxxxxxxxxxxxxx" <linux-hyperv@xxxxxxxxxxxxxxx>, "kvm@xxxxxxxxxxxxxxx" <kvm@xxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "tglx@xxxxxxxxxxxxx" <tglx@xxxxxxxxxxxxx>, "mingo@xxxxxxxxxx" <mingo@xxxxxxxxxx>, "dave.hansen@xxxxxxxxxxxxxxx" <dave.hansen@xxxxxxxxxxxxxxx>, "x86@xxxxxxxxxx" <x86@xxxxxxxxxx>, "hpa@xxxxxxxxx" <hpa@xxxxxxxxx>, "Lutomirski, Andy" <luto@xxxxxxxxxx>, "pbonzini@xxxxxxxxxx" <pbonzini@xxxxxxxxxx>, "seanjc@xxxxxxxxxx" <seanjc@xxxxxxxxxx>, "peterz@xxxxxxxxxxxxx" <peterz@xxxxxxxxxxxxx>, "Gross, Jurgen" <jgross@xxxxxxxx>, "Shankar, Ravi V" <ravi.v.shankar@xxxxxxxxx>, "mhiramat@xxxxxxxxxx" <mhiramat@xxxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "jiangshanlai@xxxxxxxxx" <jiangshanlai@xxxxxxxxx>, "nik.borisov@xxxxxxxx" <nik.borisov@xxxxxxxx>
- Delivery-date: Tue, 28 Nov 2023 18:39:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZ9cbM5vceRic94kyD24auDkj9FbCP2k4AgACNKrA=
- Thread-topic: [PATCH v12 24/37] x86/idtentry: Incorporate definitions/declarations of the FRED entries
> > FRED and IDT can share most of the definitions and declarations so
> > that in the majority of cases the actual handler implementation is the
> > same.
> >
> > The differences are the exceptions where FRED stores exception related
> > information on the stack and the sysvec implementations as FRED can
> > handle irqentry/exit() in the dispatcher instead of having it in each
> > handler.
> >
> > Also add stub defines for vectors which are not used due to Kconfig
> > decisions to spare the ifdeffery in the actual FRED dispatch code.
> >
> > Tested-by: Shan Kang <shan.kang@xxxxxxxxx>
> > Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > Signed-off-by: Xin Li <xin3.li@xxxxxxxxx>
>
> This makes me wonder too who the author is. The commit message text sounds
> like tglx. :)
You have a very good sense 😊
This is mostly from his review comments and suggestions on my original
changes to IDTENTRY. So probably I should put a "Suggested-by" instead
of "Signed-off-by" as HPA pointed out!
Thanks!
Xin
|