[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Config.mk: drop -Wdeclaration-after-statement
- To: Alexander Kanavin <alex@xxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 29 Nov 2023 08:51:11 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tU/nPNIwLiSe98DbIYyVK1ECYDGBF0SlATwijqwH0Fk=; b=dldpKMG4l0gATpk2gZgNoM9hqsV6HVnJqN2DQefxYNHux0Zy/ZxdiA6nPdtGo7HlbNWcaT9Xu5/jDPZPCv0Tma5edg4R0zevACZIfV9qeLeMY8eTc+ccVuMNcc6L4MRrMXD96hJaCOUmSNNuzpLlaMdhs36roXT8Kg5W0FOyUWJ2fCSXaWSMAseaD/ZcEpoRm5Cw+MxGEOriUM129A3z/YMg6NyOXgqJ6Txww7Q0jZkiu8Hxbncnk+mlTtGIirf5l+FfRZXBV3vVfDRYrrcNWU9xUkpcrcAQi9iV022FrLKHnLoux0/cLFNT3cpIUnPWv6qDXakqmVMYc6ne71+6Mw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CXCsyQG3psDrxoqlpCpbwqIjtbz8C71Uf7gTat6/UCoKFLXg3e3FaUmuMx6CWurGluG+NS5BRticSSft29akOdNcbUVN2nmGzfL6daFIPdQOgcxmzpmM+vrJBpPOyhlkWkANdFTm2sdfI3cDEY6MVmt8QKon3MceWSu3zfOktqpqRdGmNcFUR6GAcicy6jDDq2csPYwsTY8LejFV1PomLqqQ3J2WNQocV5wHjag1Yi6r24cvz+mx4ItVhD/G5qKbe9Xuc6c8M6wS3/xYeVNTwRIrhc02m9cPoVij/QhmJXimTUkhWGM31AIbUc7CF8fN5rRXREad3CigwKron1CvhQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 29 Nov 2023 07:51:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28.11.2023 18:47, Alexander Kanavin wrote:
> Such constructs are fully allowed by C99:
> https://gcc.gnu.org/onlinedocs/gcc-12.2.0/gcc/Mixed-Labels-and-Declarations.html#Mixed-Labels-and-Declarations
There's more to this: It may also be a policy of ours (or of any sub-component)
to demand that declarations and statements are properly separated. This would
therefore need discussing first.
> If the flag is present, then building against python 3.12 will fail thusly:
>
> | In file included from
> /srv/storage/alex/yocto/build-virt/tmp/work/core2-64-poky-linux/xen-tools/4.17+stable/recipe-sysroot/usr/include/python3.12/Python.h:44,
> | from xen/lowlevel/xc/xc.c:8:
> |
> /srv/storage/alex/yocto/build-virt/tmp/work/core2-64-poky-linux/xen-tools/4.17+stable/recipe-sysroot/usr/include/python3.12/object.h:
> In function 'Py_SIZE':
> |
> /srv/storage/alex/yocto/build-virt/tmp/work/core2-64-poky-linux/xen-tools/4.17+stable/recipe-sysroot/usr/include/python3.12/object.h:233:5:
> error: ISO C90 forbids mixed declarations and code
> [-Werror=declaration-after-statement]
> | 233 | PyVarObject *var_ob = _PyVarObject_CAST(ob);
> | | ^~~~~~~~~~~
> | In file included from
> /srv/storage/alex/yocto/build-virt/tmp/work/core2-64-poky-linux/xen-tools/4.17+stable/recipe-sysroot/usr/include/python3.12/Python.h:53:
> |
> /srv/storage/alex/yocto/build-virt/tmp/work/core2-64-poky-linux/xen-tools/4.17+stable/recipe-sysroot/usr/include/python3.12/cpython/longintrepr.h:
> In function '_PyLong_CompactValue':
> |
> /srv/storage/alex/yocto/build-virt/tmp/work/core2-64-poky-linux/xen-tools/4.17+stable/recipe-sysroot/usr/include/python3.12/cpython/longintrepr.h:121:5:
> error: ISO C90 forbids mixed declarations and code
> [-Werror=declaration-after-statement]
> | 121 | Py_ssize_t sign = 1 - (op->long_value.lv_tag &
> _PyLong_SIGN_MASK);
> | | ^~~~~~~~~~
> | cc1: all warnings being treated as errors
At least by the specific wording of the diagnostic I'm inclined to call this
a compiler bug: There's no point in mentioning C90 when -std=gnu99 was passed.
> --- a/Config.mk
> +++ b/Config.mk
> @@ -177,8 +177,6 @@ CFLAGS += -std=gnu99
Just up from here there is
CFLAGS += -std=gnu99
Yet there's no
HOSTCFLAGS += -std=gnu99
anywhere. Hence ...
> CFLAGS += -Wall -Wstrict-prototypes
>
> -$(call cc-option-add,HOSTCFLAGS,HOSTCC,-Wdeclaration-after-statement)
... imo this removal is inappropriate.
Jan
> -$(call cc-option-add,CFLAGS,CC,-Wdeclaration-after-statement)
> $(call cc-option-add,CFLAGS,CC,-Wno-unused-but-set-variable)
> $(call cc-option-add,CFLAGS,CC,-Wno-unused-local-typedefs)
>
|
