[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC XEN PATCH v2 2/3] x86/pvh: Open PHYSDEVOP_map_pirq for PVH dom0
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Thu, 30 Nov 2023 06:44:08 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UlZF+jGCmRkN4zsxWcBMVXQQdD3ujz4au5mFuhMnm+c=; b=KvIL8QtL0qrzXEZCVrhbXtEP5PJca8BnhPVOesQ1fJ7VMXRTR8LefHm4MbW8ZAqbvAZtcH8QWfu2Fgem2zjFzzBrf6S+4sBO/gPKohbErJ8m5Zt/b8Kb6ydZw/lx3nLSwtrycpFomKrXkgsNmNBmMIO2+XnwuUizkbxMAq5BPW8oTWvcqe963+Jal3NW3bg4ZgxOFYnCDtmA77IPl817dPYgtkfaIZBZkbVF3hq58RwQYhUZ286gNY6L2IQIPFY6q2NM2nEn+1tGcwLLtBIglFzuoA8PshZ9oCDK8453cMasPkRGXIWf7IcL1NO1lK6dRjBA/dxZHUyqTlwSYaq51A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KnIP/Gi26Nrwv1qNrx84hAZs29w0sd0i+JdeFvVFYXFwzNY3daVYVDTm5O1LL2GLj3rzvC4LuDUbUBuL/KxAyDboCYDDvv3etE9lWvgpo82hLK+SzmboLcOTOp9WJhrtMloD4vKs3leuLKm0sjbbw3Fvi1H335WkGDBeeXefVx9D46nam9fubYoDKdWXLHCCkYN6YX4uzhFIGM+8vta8A2YCaYssKZUixoEEr8mlSFRuWzdgZQ3K1wx+3Z3/34eeGtn6+/vE2J33nqLGCEymomF+RO2AwTr83b4qY+8Jd5r6XxvZivrd70rJ5sDQoI4v77rv9zM2gppb9FPpfka+qA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Hildebrand, Stewart" <Stewart.Hildebrand@xxxxxxx>, "Deucher, Alexander" <Alexander.Deucher@xxxxxxx>, "Ragiadakou, Xenia" <Xenia.Ragiadakou@xxxxxxx>, "Stabellini, Stefano" <stefano.stabellini@xxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, "Huang, Honglei1" <Honglei1.Huang@xxxxxxx>, "Zhang, Julia" <Julia.Zhang@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Thu, 30 Nov 2023 06:44:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHaHsLnjKJ102tGrkSg9na/6oLNI7CP3bYAgAMYyIA=
- Thread-topic: [RFC XEN PATCH v2 2/3] x86/pvh: Open PHYSDEVOP_map_pirq for PVH dom0
On 2023/11/28 23:14, Jan Beulich wrote:
> On 24.11.2023 11:41, Jiqian Chen wrote:
>> --- a/xen/arch/x86/hvm/hypercall.c
>> +++ b/xen/arch/x86/hvm/hypercall.c
>> @@ -74,6 +74,8 @@ long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void)
>> arg)
>> {
>> case PHYSDEVOP_map_pirq:
>> case PHYSDEVOP_unmap_pirq:
>> + if (is_hardware_domain(currd))
>> + break;
>> case PHYSDEVOP_eoi:
>> case PHYSDEVOP_irq_status_query:
>> case PHYSDEVOP_get_free_pirq:
>
> If you wouldn't go the route suggested by Roger, I think you will need
> to deny self-mapping requests here.
Do you mean below?
if (arg.domid == DOMID_SELF)
return;
>
> Also note that both here and in patch 1 you will want to adjust a number
> of style violations.
Could you please descript in detail? This will greatly assist me in making
modifications in the next version. Thank you!
>
> Jan
--
Best regards,
Jiqian Chen.
|
