[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/6] system/cpus: rename qemu_mutex_lock_iothread() to qemu_bql_lock()
- To: Stefan Hajnoczi <stefanha@xxxxxxxxxx>, qemu-devel@xxxxxxxxxx
- From: Cédric Le Goater <clg@xxxxxxxx>
- Date: Thu, 30 Nov 2023 13:57:28 +0100
- Cc: Jean-Christophe Dubois <jcd@xxxxxxxxxxxxxxx>, Fabiano Rosas <farosas@xxxxxxx>, qemu-s390x@xxxxxxxxxx, Song Gao <gaosong@xxxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, Thomas Huth <thuth@xxxxxxxxxx>, Hyman Huang <yong.huang@xxxxxxxxxx>, Marcelo Tosatti <mtosatti@xxxxxxxxxx>, David Woodhouse <dwmw2@xxxxxxxxxxxxx>, Andrey Smirnov <andrew.smirnov@xxxxxxxxx>, Peter Maydell <peter.maydell@xxxxxxxxxx>, Kevin Wolf <kwolf@xxxxxxxxxx>, Ilya Leoshkevich <iii@xxxxxxxxxxxxx>, Artyom Tarasenko <atar4qemu@xxxxxxxxx>, Mark Cave-Ayland <mark.cave-ayland@xxxxxxxxxxxx>, Max Filippov <jcmvbkbc@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Jagannathan Raman <jag.raman@xxxxxxxxxx>, Juan Quintela <quintela@xxxxxxxxxx>, Daniel P. Berrangé <berrange@xxxxxxxxxx>, qemu-arm@xxxxxxxxxx, Jason Wang <jasowang@xxxxxxxxxx>, Gerd Hoffmann <kraxel@xxxxxxxxxx>, Hanna Reitz <hreitz@xxxxxxxxxx>, Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>, BALATON Zoltan <balaton@xxxxxxxxxx>, Daniel Henrique Barboza <danielhb413@xxxxxxxxx>, Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>, Aurelien Jarno <aurelien@xxxxxxxxxxx>, Hailiang Zhang <zhanghailiang@xxxxxxxxxxx>, Roman Bolshakov <rbolshakov@xxxxxxx>, Huacai Chen <chenhuacai@xxxxxxxxxx>, Fam Zheng <fam@xxxxxxxxxx>, Eric Blake <eblake@xxxxxxxxxx>, Jiri Slaby <jslaby@xxxxxxx>, Alexander Graf <agraf@xxxxxxxxx>, Liu Zhiwei <zhiwei_liu@xxxxxxxxxxxxxxxxx>, Weiwei Li <liwei1518@xxxxxxxxx>, Eric Farman <farman@xxxxxxxxxxxxx>, Stafford Horne <shorne@xxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Markus Armbruster <armbru@xxxxxxxxxx>, Reinoud Zandijk <reinoud@xxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Cameron Esfahani <dirty@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Pavel Dovgalyuk <pavel.dovgaluk@xxxxxxxxx>, qemu-riscv@xxxxxxxxxx, Aleksandar Rikalo <aleksandar.rikalo@xxxxxxxxxx>, John Snow <jsnow@xxxxxxxxxx>, Sunil Muthuswamy <sunilmut@xxxxxxxxxxxxx>, Michael Roth <michael.roth@xxxxxxx>, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, Bin Meng <bin.meng@xxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, kvm@xxxxxxxxxxxxxxx, qemu-block@xxxxxxxxxx, Halil Pasic <pasic@xxxxxxxxxxxxx>, Peter Xu <peterx@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Harsh Prateek Bora <harshpb@xxxxxxxxxxxxx>, Alex Bennée <alex.bennee@xxxxxxxxxx>, Eduardo Habkost <eduardo@xxxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Vladimir Sementsov-Ogievskiy <vsementsov@xxxxxxxxxxxxxx>, qemu-ppc@xxxxxxxxxx, Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxxxxx>, Akihiko Odaki <akihiko.odaki@xxxxxxxxxx>, Leonardo Bras <leobras@xxxxxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>, Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>
- Delivery-date: Thu, 30 Nov 2023 12:58:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11/29/23 22:26, Stefan Hajnoczi wrote:
The Big QEMU Lock (BQL) has many names and they are confusing. The
actual QemuMutex variable is called qemu_global_mutex but it's commonly
referred to as the BQL in discussions and some code comments. The
locking APIs, however, are called qemu_mutex_lock_iothread() and
qemu_mutex_unlock_iothread().
The "iothread" name is historic and comes from when the main thread was
split into into KVM vcpu threads and the "iothread" (now called the main
loop thread). I have contributed to the confusion myself by introducing
a separate --object iothread, a separate concept unrelated to the BQL.
The "iothread" name is no longer appropriate for the BQL. Rename the
locking APIs to:
- void qemu_bql_lock(void)
- void qemu_bql_unlock(void)
- bool qemu_bql_locked(void)
There are more APIs with "iothread" in their names. Subsequent patches
will rename them. There are also comments and documentation that will be
updated in later patches.
Signed-off-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
Reviewed-by: Cédric Le Goater <clg@xxxxxxxx>
Thanks,
C.
|