[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/6] Rename "QEMU global mutex" to "BQL" in comments and docs
- To: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
- From: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
- Date: Thu, 30 Nov 2023 15:37:18 -0500
- Cc: qemu-devel@xxxxxxxxxx, Jean-Christophe Dubois <jcd@xxxxxxxxxxxxxxx>, Fabiano Rosas <farosas@xxxxxxx>, qemu-s390x@xxxxxxxxxx, Song Gao <gaosong@xxxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, Thomas Huth <thuth@xxxxxxxxxx>, Hyman Huang <yong.huang@xxxxxxxxxx>, Marcelo Tosatti <mtosatti@xxxxxxxxxx>, David Woodhouse <dwmw2@xxxxxxxxxxxxx>, Andrey Smirnov <andrew.smirnov@xxxxxxxxx>, Peter Maydell <peter.maydell@xxxxxxxxxx>, Kevin Wolf <kwolf@xxxxxxxxxx>, Ilya Leoshkevich <iii@xxxxxxxxxxxxx>, Artyom Tarasenko <atar4qemu@xxxxxxxxx>, Mark Cave-Ayland <mark.cave-ayland@xxxxxxxxxxxx>, Max Filippov <jcmvbkbc@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Jagannathan Raman <jag.raman@xxxxxxxxxx>, Juan Quintela <quintela@xxxxxxxxxx>, Daniel P. Berrangé <berrange@xxxxxxxxxx>, qemu-arm@xxxxxxxxxx, Jason Wang <jasowang@xxxxxxxxxx>, Gerd Hoffmann <kraxel@xxxxxxxxxx>, Hanna Reitz <hreitz@xxxxxxxxxx>, Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>, BALATON Zoltan <balaton@xxxxxxxxxx>, Daniel Henrique Barboza <danielhb413@xxxxxxxxx>, Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>, Aurelien Jarno <aurelien@xxxxxxxxxxx>, Hailiang Zhang <zhanghailiang@xxxxxxxxxxx>, Roman Bolshakov <rbolshakov@xxxxxxx>, Huacai Chen <chenhuacai@xxxxxxxxxx>, Fam Zheng <fam@xxxxxxxxxx>, Eric Blake <eblake@xxxxxxxxxx>, Jiri Slaby <jslaby@xxxxxxx>, Alexander Graf <agraf@xxxxxxxxx>, Liu Zhiwei <zhiwei_liu@xxxxxxxxxxxxxxxxx>, Weiwei Li <liwei1518@xxxxxxxxx>, Eric Farman <farman@xxxxxxxxxxxxx>, Stafford Horne <shorne@xxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Markus Armbruster <armbru@xxxxxxxxxx>, Reinoud Zandijk <reinoud@xxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Cameron Esfahani <dirty@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Pavel Dovgalyuk <pavel.dovgaluk@xxxxxxxxx>, qemu-riscv@xxxxxxxxxx, Aleksandar Rikalo <aleksandar.rikalo@xxxxxxxxxx>, John Snow <jsnow@xxxxxxxxxx>, Sunil Muthuswamy <sunilmut@xxxxxxxxxxxxx>, Michael Roth <michael.roth@xxxxxxx>, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, Bin Meng <bin.meng@xxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, kvm@xxxxxxxxxxxxxxx, qemu-block@xxxxxxxxxx, Halil Pasic <pasic@xxxxxxxxxxxxx>, Peter Xu <peterx@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Harsh Prateek Bora <harshpb@xxxxxxxxxxxxx>, Alex Bennée <alex.bennee@xxxxxxxxxx>, Eduardo Habkost <eduardo@xxxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Vladimir Sementsov-Ogievskiy <vsementsov@xxxxxxxxxxxxxx>, Cédric Le Goater <clg@xxxxxxxx>, qemu-ppc@xxxxxxxxxx, Christian Borntraeger <borntraeger@xxxxxxxxxxxxx>, Akihiko Odaki <akihiko.odaki@xxxxxxxxxx>, Leonardo Bras <leobras@xxxxxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>, Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>
- Delivery-date: Thu, 30 Nov 2023 20:37:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Nov 30, 2023 at 02:49:48PM +0100, Philippe Mathieu-Daudé wrote:
> On 29/11/23 22:26, Stefan Hajnoczi wrote:
> > The term "QEMU global mutex" is identical to the more widely used Big
> > QEMU Lock ("BQL"). Update the code comments and documentation to use
> > "BQL" instead of "QEMU global mutex".
> >
> > Signed-off-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
> > ---
> > docs/devel/multi-thread-tcg.rst | 7 +++----
> > docs/devel/qapi-code-gen.rst | 2 +-
> > docs/devel/replay.rst | 2 +-
> > docs/devel/multiple-iothreads.txt | 16 ++++++++--------
> > include/block/blockjob.h | 6 +++---
> > include/io/task.h | 2 +-
> > include/qemu/coroutine-core.h | 2 +-
> > include/qemu/coroutine.h | 2 +-
> > hw/block/dataplane/virtio-blk.c | 8 ++++----
> > hw/block/virtio-blk.c | 2 +-
> > hw/scsi/virtio-scsi-dataplane.c | 6 +++---
> > net/tap.c | 2 +-
> > 12 files changed, 28 insertions(+), 29 deletions(-)
>
>
> > diff --git a/include/block/blockjob.h b/include/block/blockjob.h
> > index e594c10d23..b2bc7c04d6 100644
> > --- a/include/block/blockjob.h
> > +++ b/include/block/blockjob.h
> > @@ -54,7 +54,7 @@ typedef struct BlockJob {
> > /**
> > * Speed that was set with @block_job_set_speed.
> > - * Always modified and read under QEMU global mutex
> > (GLOBAL_STATE_CODE).
> > + * Always modified and read under BQL (GLOBAL_STATE_CODE).
>
> "under the BQL"
>
> > */
> > int64_t speed;
> > @@ -66,7 +66,7 @@ typedef struct BlockJob {
> > /**
> > * Block other operations when block job is running.
> > - * Always modified and read under QEMU global mutex
> > (GLOBAL_STATE_CODE).
> > + * Always modified and read under BQL (GLOBAL_STATE_CODE).
>
> Ditto,
>
> > */
> > Error *blocker;
> > @@ -89,7 +89,7 @@ typedef struct BlockJob {
> > /**
> > * BlockDriverStates that are involved in this block job.
> > - * Always modified and read under QEMU global mutex
> > (GLOBAL_STATE_CODE).
> > + * Always modified and read under BQL (GLOBAL_STATE_CODE).
>
> Ditto.
>
> > */
> > GSList *nodes;
> > } BlockJob;
Will fix in v2.
Stefan
Attachment:
signature.asc
Description: PGP signature
|