Re: [XEN PATCH 6/7] xen/x86: remove stale comment

[Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>]

On 2023-11-30 17:41, Jan Beulich wrote:
> On 29.11.2023 16:24, Nicola Vetrini wrote:
> > The comment referred to the declaration for do_mca, which
> > now is part of hypercall-defs.h, therefore the comment is stale.
> If the comments were stale, the #include-s should also be able to
> disappear?
>
> > --- a/xen/arch/x86/cpu/mcheck/mce.c
> > +++ b/xen/arch/x86/cpu/mcheck/mce.c
> > @@ -14,7 +14,7 @@
> >  #include <xen/cpumask.h>
> >  #include <xen/event.h>
> >  #include <xen/guest_access.h>
> > -#include <xen/hypercall.h> /* for do_mca */
> > +#include <xen/hypercall.h>
> >  #include <xen/cpu.h>
> Here specifically I think the comment isn't stale, as xen/hypercall.h
> includes xen/hypercall-defs.h.
Ok, I see your point

> > --- a/xen/arch/x86/include/asm/hypercall.h
> > +++ b/xen/arch/x86/include/asm/hypercall.h
> > @@ -12,7 +12,7 @@
> >  #include <xen/types.h>
> >  #include <public/physdev.h>
> >  #include <public/event_channel.h>
> > -#include <public/arch-x86/xen-mca.h> /* for do_mca */
> > +#include <public/arch-x86/xen-mca.h>
> >  #include <asm/paging.h>
> Here otoh I'm not even sure this public header (or the others) is (are)
> really needed.
I confirm this. It build even without this header.

--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)