[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC KERNEL PATCH v2 1/3] xen/pci: Add xen_reset_device_state function
- To: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Mon, 4 Dec 2023 08:49:56 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lSYNP17FW+d29WFtlOlSR8mnGPm95Lfk7PNHYinfE+U=; b=bYf5rMJBYGX57+w1W0KAApgKUz7grYtxoThRtPVLwX1MJvX9stN72RVrf8EQ0atGwuNtwkQoCJt0Iipv6Wi+nUQMQW1Y9GJwfZplpVGmn1INQ6wWrzxicOKgY7KAFkBa81gp16Z8LVmCiGUyr2Jp+tFQJOQm8GqTb3Z+prkE4PO2ZMze32UCWfJcxrDppsZzpT6+pbnvVNOJ9o7SnLvCnHSMaEKgNf8ispYCovPF54niTk0XYBxcEG3/t0rga96aRpCzcPsKrtWOlaWKfdHMXFU2WJmsIQ+WnsZPHfNqcfukRC1uUAPf+fbUZizbZM54tmG9kgPe9lTk1vKzNEed/A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BDP22pmEpabUF8CYEnobLuE0MYpSO5ah4nUTUh2asQCdE8+xZYzsMAehDYnKqEMzmH+Q/FFoudbDmZXZz9chyqyAMdsZOXGcmtpxquA1xoxTYFGAvIBHxv8/+lWsUuls7gqYVy4in4DzZDaM3pTy9ePOWDQZ4TOG0tawzsWgnnCXcXEEUgnkE91KKgW7Nd//PSEssUuVUc9BelChjqxW7IKxbAjhoeFOf+/nWeGq6l0hSb/kP9wHXInFyKMz0QTBLP+Kus3V0d386cd73Du4inv3RLBfi0WxsMLshYUrKZ+x7QPufYHfsPCYptT6xk1nht+tCL5YE3W9Dp5KoID+Fg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, "Rafael J . Wysocki" <rafael@xxxxxxxxxx>, Len Brown <lenb@xxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-acpi@xxxxxxxxxxxxxxx" <linux-acpi@xxxxxxxxxxxxxxx>, "Stabellini, Stefano" <stefano.stabellini@xxxxxxx>, "Deucher, Alexander" <Alexander.Deucher@xxxxxxx>, "Koenig, Christian" <Christian.Koenig@xxxxxxx>, "Hildebrand, Stewart" <Stewart.Hildebrand@xxxxxxx>, "Ragiadakou, Xenia" <Xenia.Ragiadakou@xxxxxxx>, "Huang, Honglei1" <Honglei1.Huang@xxxxxxx>, "Zhang, Julia" <Julia.Zhang@xxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Mon, 04 Dec 2023 08:50:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHaHsGaWb8EJvAynUiF4JhdQXSstLCY0coAgACRkoA=
- Thread-topic: [RFC KERNEL PATCH v2 1/3] xen/pci: Add xen_reset_device_state function
On 2023/12/4 15:58, Thomas Gleixner wrote:
> On Fri, Nov 24 2023 at 18:31, Jiqian Chen wrote:
>> When device on dom0 side has been reset, the vpci on Xen side
>> won't get notification, so that the cached state in vpci is
>> all out of date with the real device state.
>> To solve that problem, this patch add a function to clear all
>
> Please get rid of 'this patch' all over the series.
>
> # grep -r 'This patch' Documentation/process/
Thanks. I will remove "this patch" or "I/we" in next version.
>
>> vpci device state when device is reset on dom0 side.
>>
>> And call that function in pcistub_init_device. Because when
>> we use "pci-assignable-add" to assign a passthrough device in
>> Xen, it will reset passthrough device and the vpci state will
>> out of date, and then device will fail to restore bar state.
>>
>> Signed-off-by: Jiqian Chen <Jiqian.Chen@xxxxxxx>
>> Signed-off-by: Huang Rui <ray.huang@xxxxxxx>
>
> This Signed-off-by chain is incorrect.
>
> Documentation/process/submitting-patches.rst has a full chapter about
> S-O-B and the correct usage.
I am the author of this series of patches, and Huang Rui transported the v1 to
upstream. And now I transport v2. I am not aware that the SOB chain is
incorrect.
Do you have any suggestions?
>
> Thanks,
>
> tglx
--
Best regards,
Jiqian Chen.
|
