Xen project Mailing List

Re: Moving domain from credit2 to credit cpupool crash xen

To: René Winther Højgaard <renewin@xxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>

Date: Mon, 4 Dec 2023 10:23:58 +0100

Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none

Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=my/b24KJPWtpI9z0upvFzWYYmWySoD5UmkW4tA2ie9c=; b=ZZcX0K8//OhpmiiEPf1Rc5dHMa2NoEPGON+yetKMV+sC8zWDHEU4g2YXd68mCBImPySubA7t0+6rSHyf8n7eObj+5849fdAytO9Kzz/O1gK+CKfqdSxsLlT+0jeQfQG9ZvwI4J/X0MiAMZkljBiqQ+m0+bfhQvslt4D1am/yu5MTvpehGrqX+p+9s/cmqsXdhMxCk9qvAJyzaTno2PnRE4FMc9Q6ks8IK3PFOVkGBK3ykTCXCMQjBywlPLNSV1Pn0rT+Ee1W2pWHc0oizbvPk5KAsMdW1MzcZtfLcsQRjDNA+DLLfZVck+7cA+ALaz854ekJEIziOYKjUUY8QHXmfA==

Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T3BTvI+hpVi/KL8Weg0OTiFmqKUyk55yo43s16aaw95z4cDWuOoq+xXmothfD5559PJ0Yd1baB6UeiXTAwsYIBKzxQMTD7fYr2N0/xqRZbB7uL2lr7WmPUoBqaPolujkyojm2d1qpt7QzX9ETWptJWr6Dnyo5MPk3yTZARhzpzY/LQRBy9A6q9duHtMTJoQAPMgA3bDDrUtbJBYhgxpmof4c30gvJB/jAjcAfMs9TyMXwnn7WnALu7xL138mMswE6/YBT52GDJXvrk8Q1qzB82HYSerUGXZQAAi5cp0xSQsi3nOJpLnXQjGMuNa9RB2v3HpaNFix04gYlu51E9YH9w==

Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;

Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL

Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>

Delivery-date: Mon, 04 Dec 2023 09:24:06 +0000

List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 01.12.2023 21:13, René Winther Højgaard wrote: > When I move a domain from pool0 with credit2 to any pool with credit(1) I get > the following crash. > > > Software: Xen-4.17.3 / Qubes OS 4.2.0-RC5 > Firmware: Dasharo 0.9.0 - Z790P > Hardware: 13900K > (XEN) Xen BUG at common/sched/credit.c:1051(XEN) ----[ Xen-4.17.3-pre x86_64 > debug=y Not tainted ]---- > (XEN) CPU: 2 > (XEN) RIP: e008:[<ffff82d040237cfd>] credit.c#csched_free_udata+0x12/0x14 > (XEN) RFLAGS: 0000000000010202 CONTEXT: hypervisor (d0v2) > (XEN) rax: ffff82d040237ceb rbx: 0000000000000014 rcx: 0000000000000013 > (XEN) rdx: ffff831087d7ffff rsi: ffff830ad80e8da0 rdi: ffff830ad80e8da0 > (XEN) rbp: 0000000000000000 rsp: ffff831087d7fc90 r8: ffff830e2d6a49b0 > (XEN) r9: ffff831087d7fbe0 r10: ffff83107c481068 r11: 0000002cfd1c274a > (XEN) r12: ffff830ad80e8c80 r13: ffff83107c45bee0 r14: 0000000000000000 > (XEN) r15: ffff82d0405a9288 cr0: 0000000080050033 cr4: 0000000000b526e0 > (XEN) cr3: 00000009284d8000 cr2: 00007fb535181240 > (XEN) fsb: 00007fb534c5f380 gsb: ffff8881b9d00000 gss: 0000000000000000 > (XEN) ds: 0000 es: 0000 fs: 0000 gs: 0000 ss: e010 cs: e008 > (XEN) Xen code around <ffff82d040237cfd> > (credit.c#csched_free_udata+0x12/0x14): > (XEN) 75 06 e8 19 74 ff ff c3 <0f> 0b f3 0f 1e fa 53 48 8b 5f 18 48 85 db 74 > 2b > (XEN) Xen stack trace from rsp=ffff831087d7fc90: > (XEN) ffff82d040247503 0000001300002030 ffff830ad80e8bf0 ffff82d0405a9288 > (XEN) ffff83107f59aa80 ffff830ad80e8c80 ffff83107c45bee0 ffff830ad80e8bf0 > (XEN) ffff831000af1010 ffff83107c45bee0 ffff830ad80ed000 ffff83107c45bee0 > (XEN) 0000000000000000 ffff82d04045d5d8 ffff82d0405ae680 ffff82d040235303 > (XEN) ffff831087d7fe20 00000000fffffffe ffff82d040236ec3 ffff830ad80ed000 > (XEN) 0000000000000000 00007fb535230010 ffff831087d7ffff 0000000000000000 > (XEN) ffff82d04045d5d8 ffff82d040234763 00000000c0000102 0000000000000000 > (XEN) 0000000000000000 00000000c0000102 0000000d00000000 ffffffff8101ede6 > (XEN) 000000000000e033 0000000000011082 ffffc90046ebba90 000000000000e02b > (XEN) 5a33a1a65352beef feadf9effdf1beef 122ae2fa736bbeef 46023e9af174beef > (XEN) ffff82d040227cc6 ffff831087d7fe48 0000000000000000 0000000000011082 > (XEN) 0000000000000000 ffff831087d7ffff 0000000000000000 ffffffff8101ede4 > (XEN) ffff82d0403495d0 0000001500000012 0000000100000006 0000000d00000000 > (XEN) 00007ffdf93fb3fc 0000000000431042 000000000043d990 000000000043d9b0 > (XEN) 00007fb534eb8434 00007ffdf93fb400 0000000000000013 0000000002361838 > (XEN) 04457fe81f7cf300 0000000002360870 ffffffffffffff80 0000000000000000 > (XEN) 00007ffdf93fc652 000000000043d980 ffff831087d7fef8 0000000000000023 > (XEN) ffff83107f544000 0000000000000000 0000000000000000 0000000000000000 > (XEN) ffff82d0402dd07f ffff83107f544000 0000000000000000 0000000000000000 > (XEN) ffff82d0402012b7 0000000000000000 ffff88811abbc100 00007ffdf93fb2c0 > (XEN) Xen call trace: > (XEN) [<ffff82d040237cfd>] R credit.c#csched_free_udata+0x12/0x14 > (XEN) [<ffff82d040247503>] S sched_move_domain+0x5b0/0x5cc Hmm, looks like sched_move_domain()'s calling of sched_free_udata() uses the new pool's scheduler, not that of the original pool. I'm puzzled though that there's no sign at all in the function of it caring about what the original pool was. IOW I'm not sure that the simple and obvious change to latch the original pool into a local and then use it on the "out_free" path is going to be enough. Jürgen (sorry, again you)? Jan

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.