[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/12] virtio-scsi: replace AioContext lock with tmf_bh_lock
- To: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
- From: Kevin Wolf <kwolf@xxxxxxxxxx>
- Date: Mon, 4 Dec 2023 13:35:27 +0100
- Cc: qemu-devel@xxxxxxxxxx, Hanna Reitz <hreitz@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Alberto Garcia <berto@xxxxxxxxxx>, Emanuele Giuseppe Esposito <eesposit@xxxxxxxxxx>, John Snow <jsnow@xxxxxxxxxx>, Eric Blake <eblake@xxxxxxxxxx>, Wen Congyang <wencongyang2@xxxxxxxxxx>, qemu-block@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, Coiby Xu <Coiby.Xu@xxxxxxxxx>, Eduardo Habkost <eduardo@xxxxxxxxxxx>, Xie Changlong <xiechanglong.d@xxxxxxxxx>, Ari Sundholm <ari@xxxxxxxxxx>, Li Zhijian <lizhijian@xxxxxxxxxxx>, Cleber Rosa <crosa@xxxxxxxxxx>, Juan Quintela <quintela@xxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Daniel P. Berrangé <berrange@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Vladimir Sementsov-Ogievskiy <vsementsov@xxxxxxxxxxxxxx>, Zhang Chen <chen.zhang@xxxxxxxxx>, Peter Xu <peterx@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Leonardo Bras <leobras@xxxxxxxxxx>, Pavel Dovgalyuk <pavel.dovgaluk@xxxxxxxxx>, Fam Zheng <fam@xxxxxxxxxx>, Fabiano Rosas <farosas@xxxxxxx>
- Delivery-date: Mon, 04 Dec 2023 12:35:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Am 29.11.2023 um 20:55 hat Stefan Hajnoczi geschrieben:
> Protect the Task Management Function BH state with a lock. The TMF BH
> runs in the main loop thread. An IOThread might process a TMF at the
> same time as the TMF BH is running. Therefore tmf_bh_list and tmf_bh
> must be protected by a lock.
>
> Run TMF request completion in the IOThread using aio_wait_bh_oneshot().
> This avoids more locking to protect the virtqueue and SCSI layer state.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
Reviewed-by: Kevin Wolf <kwolf@xxxxxxxxxx>
|
