[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/12] aio: make aio_context_acquire()/aio_context_release() a no-op
- To: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
- From: Kevin Wolf <kwolf@xxxxxxxxxx>
- Date: Mon, 4 Dec 2023 14:18:42 +0100
- Cc: qemu-devel@xxxxxxxxxx, Hanna Reitz <hreitz@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Alberto Garcia <berto@xxxxxxxxxx>, Emanuele Giuseppe Esposito <eesposit@xxxxxxxxxx>, John Snow <jsnow@xxxxxxxxxx>, Eric Blake <eblake@xxxxxxxxxx>, Wen Congyang <wencongyang2@xxxxxxxxxx>, qemu-block@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, Coiby Xu <Coiby.Xu@xxxxxxxxx>, Eduardo Habkost <eduardo@xxxxxxxxxxx>, Xie Changlong <xiechanglong.d@xxxxxxxxx>, Ari Sundholm <ari@xxxxxxxxxx>, Li Zhijian <lizhijian@xxxxxxxxxxx>, Cleber Rosa <crosa@xxxxxxxxxx>, Juan Quintela <quintela@xxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Daniel P. Berrangé <berrange@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Vladimir Sementsov-Ogievskiy <vsementsov@xxxxxxxxxxxxxx>, Zhang Chen <chen.zhang@xxxxxxxxx>, Peter Xu <peterx@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Leonardo Bras <leobras@xxxxxxxxxx>, Pavel Dovgalyuk <pavel.dovgaluk@xxxxxxxxx>, Fam Zheng <fam@xxxxxxxxxx>, Fabiano Rosas <farosas@xxxxxxx>
- Delivery-date: Mon, 04 Dec 2023 13:18:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Am 29.11.2023 um 20:55 hat Stefan Hajnoczi geschrieben:
> aio_context_acquire()/aio_context_release() has been replaced by
> fine-grained locking to protect state shared by multiple threads. The
> AioContext lock still plays the role of balancing locking in
> AIO_WAIT_WHILE() and many functions in QEMU either require that the
> AioContext lock is held or not held for this reason. In other words, the
> AioContext lock is purely there for consistency with itself and serves
> no real purpose anymore.
>
> Stop actually acquiring/releasing the lock in
> aio_context_acquire()/aio_context_release() so that subsequent patches
> can remove callers across the codebase incrementally.
>
> I have performed "make check" and qemu-iotests stress tests across
> x86-64, ppc64le, and aarch64 to confirm that there are no failures as a
> result of eliminating the lock.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
YOLO.
Acked-by: Kevin Wolf <kwolf@xxxxxxxxxx>
|
