[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tools/libs/evtchn: drop assert()s in stubdom



On Wed, Dec 6, 2023 at 9:40 AM Juergen Gross <jgross@xxxxxxxx> wrote:
>
> In tools/libs/evtchn/minios.c there are assert()s for the current
> thread being the main thread when binding an event channel.
>
> As Mini-OS is supporting multiple threads, there is no real reason
> why the binding shouldn't be allowed to happen in any other thread.
>
> Just drop the assert()s.
>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> ---
>  tools/libs/evtchn/minios.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/tools/libs/evtchn/minios.c b/tools/libs/evtchn/minios.c
> index 28743cb055..e33ddec7e7 100644
> --- a/tools/libs/evtchn/minios.c
> +++ b/tools/libs/evtchn/minios.c
> @@ -195,7 +195,6 @@ xenevtchn_port_or_error_t 
> xenevtchn_bind_unbound_port(xenevtchn_handle *xce,
>      int ret;
>      evtchn_port_t port;
>
> -    assert(get_current() == main_thread);
>      port_info = port_alloc(xce);

If multiple threads are allowed, does port_list need to gain a lock
protecting it?

Regards,
Jason



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.