[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 15/29] tools/libs/light: add backend type for 9pfs PV devices



On Wed, Dec 6, 2023 at 12:44 PM Nick Rosbrook <rosbrookn@xxxxxxxxx> wrote:
>
> On Wed, Dec 6, 2023 at 9:36 AM Jason Andryuk <jandryuk@xxxxxxxxx> wrote:
> > FYI, these IDL changes will require golang binding regeneration.
> > (Maybe we shouldn't have generated code checked in...)
>
> The generated code needs to be checked in for it to work as a go module.

I don't follow. The build system generates the *.gen.go binding files
if they are missing.  They can then be used, installed or packaged.
Why do they need to be checked into the git repo?  Checked in, they
have a tendency to go stale.

Regards,
Jason



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.