Re: [PATCH v2 2/3] xen/sched: fix sched_move_domain()

[George Dunlap <george.dunlap@xxxxxxxxx>]

On Mon, Dec 4, 2023 at 4:56 PM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 04.12.2023 16:23, Juergen Gross wrote:
> > Do cleanup in sched_move_domain() in a dedicated service function,
> > which is called either in error case with newly allocated data, or in
> > success case with the old data to be freed.
> >
> > This will at once fix some subtle bugs which sneaked in due to
> > forgetting to overwrite some pointers in the error case.
> >
> > Fixes: 70fadc41635b ("xen/cpupool: support moving domain between cpupools 
> > with different granularity")
> > Reported-by: René Winther Højgaard <renewin@xxxxxxxxx>
> > Initial-fix-by: Jan Beulich <jbeulich@xxxxxxxx>
> > Initial-fix-by: George Dunlap <george.dunlap@xxxxxxxxx>
> > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Still not a fan of removing the "out:" label, but anyway:

Acked-by: George Dunlap <george.dunlap@xxxxxxxxx>