[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: ARM: MISRA C:2012 Rule 5.6
On 07/12/2023 12:44, Jan Beulich wrote: On 07.12.2023 12:48, Federico Serafini wrote:On 07/12/23 12:43, Federico Serafini wrote:Hello everyone, Rule 5.6 states that a typedef name shall be a unique identifier. This is to avoid developer confusion. For ARM, the violations left [1] are generated by two definitions of the type phys_addr_t within two different files. I would like to ask if this is intentional or not: if it is intentional and it is not causing any confusion between XEN developers, then I think violations involving phys_addr_t can be deviated. [1] https://saas.eclairit.com:3787/fs/var/local/eclair/XEN.ecdf/ECLAIR_normal/staging/ARM64-2023/429/PROJECT.ecd;/by_service/MC3R1.R5.6.htmlAdding XEN mailing list in CC.Thanks. These are files ported from Linux, where I assume the typedef-s were added to limit the changes which would need making elsewhere. Still I think that's exactly what we (now) have xen/linux-compat.h for. IOW - just move the typedef-s there? +1. I was about to suggest the same. Cheers, -- Julien Grall
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |