Re: [PATCH v2 1/5] automation: Add a Dockerfile for running FVP_Base jobs

[Henry Wang <Henry.Wang@xxxxxxx>]

Hi Julien,

> On Dec 8, 2023, at 20:30, Julien Grall <julien@xxxxxxx> wrote:
> 
> Hi,
> 
> On 08/12/2023 05:46, Henry Wang wrote:
>> Fixed Virtual Platforms (FVPs) are complete simulations of an Arm
>> system, including processor, memory and peripherals. These are set
>> out in a "programmer's view", which gives programmers a comprehensive
>> model on which to build and test software. FVP can be configured to
>> different setups by its cmdline parameters, and hence having the FVP
>> in CI will provide us with the flexibility to test Arm features and
>> setups that we find difficult to use real hardware or emulators.
>> This commit adds a Dockerfile for the new arm64v8 container with
>> FVP installed, based on the debian bookworm-arm64v8 image. This
>> container will be used to run the FVP test jobs. Compared to the
>> debian bookworm-arm64v8 image, the packages in the newly added FVP
>> container does not contain the `u-boot-qemu`, and adds the `expect`
>> to run expect scripts introduced by following commits, `telnet` to
>> connect to FVP, and `tftpd-hpa` to provide the TFTP service for
>> the FVP.
>> Signed-off-by: Henry Wang <Henry.Wang@xxxxxxx>
>> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>> ---
>> v2:
>> - Add Stefano's Reviewed-by tag.
>> ---
>> +
>> +RUN wget 
>> https://developer.arm.com/-/media/Files/downloads/ecosystem-models/FVP_Base_RevC-2xAEMvA_${FVP_BASE_VERSION}.tgz
>>  && \
> 
> I vaguely recall some discussions on whether it was ok for us to publish a 
> container with the FVP model due to the license agreement.
> 
> I guess this has now been resolved because the download can be done without 
> sign-in to the account. Can you confirm?

Yes, quoting some words from the people we asked internally:
(the page referred to is 
https://developer.arm.com/Tools%20and%20Software/Fixed%20Virtual%20Platforms):

"All the FVPs referenced on this page that you are interested in are licensed 
under
lightweight Eco System EULA that has no restrictions on the redistribution.”

"So, yes, we can ship container images containing the FVP and the license on 
the FVP will remain as is.”

"No issues with redistributing the model package in a Docker container, as long 
as the EULA in included."

> It would also be good that the commit message indicates whether there is any 
> implicit license agreement from Xen Project (or any user that decide to use 
> our scripts).

I think it is the “END USER LICENSE AGREEMENT FOR ARM ECOSYSTEM MODELS”?

Kind regards,
Henry

> 
> Cheers,
> 
> -- 
> Julien Grall