[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 04/14] aio: make aio_context_acquire()/aio_context_release() a no-op
- To: Kevin Wolf <kwolf@xxxxxxxxxx>
- From: Stefan Hajnoczi <stefanha@xxxxxxxxx>
- Date: Wed, 20 Dec 2023 08:40:04 -0500
- Cc: Stefan Hajnoczi <stefanha@xxxxxxxxxx>, qemu-devel@xxxxxxxxxx, Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>, Vladimir Sementsov-Ogievskiy <vsementsov@xxxxxxxxxxxxxx>, Cleber Rosa <crosa@xxxxxxxxxx>, Xie Changlong <xiechanglong.d@xxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Ari Sundholm <ari@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Eric Blake <eblake@xxxxxxxxxx>, John Snow <jsnow@xxxxxxxxxx>, Eduardo Habkost <eduardo@xxxxxxxxxxx>, Wen Congyang <wencongyang2@xxxxxxxxxx>, Alberto Garcia <berto@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, qemu-block@xxxxxxxxxx, Juan Quintela <quintela@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Coiby Xu <Coiby.Xu@xxxxxxxxx>, Fabiano Rosas <farosas@xxxxxxx>, Hanna Reitz <hreitz@xxxxxxxxxx>, Zhang Chen <chen.zhang@xxxxxxxxx>, Daniel P. Berrangé <berrange@xxxxxxxxxx>, Pavel Dovgalyuk <pavel.dovgaluk@xxxxxxxxx>, Peter Xu <peterx@xxxxxxxxxx>, Emanuele Giuseppe Esposito <eesposit@xxxxxxxxxx>, Fam Zheng <fam@xxxxxxxxxx>, Leonardo Bras <leobras@xxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Li Zhijian <lizhijian@xxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 20 Dec 2023 13:40:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, 20 Dec 2023 at 04:32, Kevin Wolf <kwolf@xxxxxxxxxx> wrote:
>
> Am 19.12.2023 um 22:23 hat Stefan Hajnoczi geschrieben:
> > The following hack makes the test pass but there are larger safety
> > issues that I'll need to look at on Wednesday:
>
> I see, you're taking the same approach as in the SCSI layer: Don't make
> things thread-safe, but just always access them from the same thread.
Yes, but it feels like a hack to me. You pointed out that other parts
also don't look thread-safe (e.g. the clients list) and I agree. I've
started annotating the code and will try to come up with a full fix
today.
Stefan
|
