Re: [PATCH v2 3/7] xen/common: Move Arm's bootfdt to common

[Julien Grall <julien@xxxxxxx>]

Hi Shawn,

On 15/12/2023 02:43, Shawn Anastasio wrote:
> Move Arm's bootfdt.c to xen/common so that it can be used by other
> device tree architectures like PPC and RISCV. Only a minor change to
> conditionalize a call to a function only available on EFI-supporting
> targets was made to the code itself. >
> Suggested-by: Julien Grall <julien@xxxxxxx>
> Signed-off-by: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
With the MAINTAINERS file updated (I would add under DEVICE TREE) and 
one note below:
Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

> --- a/xen/arch/arm/bootfdt.c
> +++ b/xen/common/device-tree/bootfdt.c
> @@ -431,12 +431,15 @@ static int __init early_scan_node(const void *fdt,
>   {
>       int rc = 0;
>   
> -    /*
> -     * If Xen has been booted via UEFI, the memory banks are
> -     * populated. So we should skip the parsing.
> -     */
> -    if ( !efi_enabled(EFI_BOOT) &&
> -         device_tree_node_matches(fdt, node, "memory") )
> +    if ( device_tree_node_matches(fdt, node, "memory") )
> +#if defined(CONFIG_ARM_EFI)
As discussed in a separate subthread, I would be ok with any of the 
options proposed. So feel free ot keep my Acked-by once this is settled.
Cheers,

--
Julien Grall