Re: [PATCH v2 15/29] tools/libs/light: add backend type for 9pfs PV devices

[Nick Rosbrook <rosbrookn@xxxxxxxxx>]

On Wed, Dec 6, 2023 at 1:53 PM Jason Andryuk <jandryuk@xxxxxxxxx> wrote:
>
> On Wed, Dec 6, 2023 at 12:44 PM Nick Rosbrook <rosbrookn@xxxxxxxxx> wrote:
> >
> > On Wed, Dec 6, 2023 at 9:36 AM Jason Andryuk <jandryuk@xxxxxxxxx> wrote:
> > > FYI, these IDL changes will require golang binding regeneration.
> > > (Maybe we shouldn't have generated code checked in...)
> >
> > The generated code needs to be checked in for it to work as a go module.
>
> I don't follow. The build system generates the *.gen.go binding files
> if they are missing.  They can then be used, installed or packaged.
> Why do they need to be checked into the git repo?  Checked in, they
> have a tendency to go stale.
>

That's not how go modules are typically consumed. E.g., the Debian
packages with go source code are only there to satisfy Build-Depends
of other packages. One can use locally installed go modules as
overrides at build-time, but normally go modules are fetched via git
(internally by the go tooling) according to what is specified in a
project's go.mod file. See https://go.dev/blog/using-go-modules for
more.

-Nick