[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 05/11] virtio-gpu: Introduce virgl_gpu_resource structure
- To: Akihiko Odaki <akihiko.odaki@xxxxxxxxxx>
- From: Huang Rui <ray.huang@xxxxxxx>
- Date: Wed, 3 Jan 2024 16:48:47 +0800
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dn2ThuHqlgJOFeiBw7gJaeZ7iDX0yPVeR+GYzaTbJ/Y=; b=Ufv8P9IaJSoLapmU7cIL4hceE9EYW+nCGYg+j+Pq5MKpymIU9tb7vJ9FhAxXS+QWp1c10PYJn16k6mmm9eAFUFS+sLRNH4qHekVbn6tbAe7MmtQiyRqYjUV6UUokQF8gorkzvatO4fxqkKGL5JzgjngL9ACre71wSZGlZW+KRHfQT6eOkltKeL7+BFjkvicMvxa3+SpH3oAymVdwHFZvf4QpBezC3ZkLAis4vaPjicMWIOrYrDEw7q7qNcu+Au839YrN4Ohcef/ZeDtNpa3c4ocH1bDPKUuDzLXIEa5eOBgTHgDWYDQPeG+I5FnRuhiXCk5KUmzBMY1EpUb9WdnfrQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c5pWTeRjfLlrr5CuzPG8UtFL2Vyap2570rOYsyFhptFAQ2wPbFpyV3d0/XNNjXS8BB1GF6moaMM7C+72j+5Dj4K91Vm0QNRqxqPUadwRgzxJROc7AeAWvzIje1Z0OhEwk4mSLgkAfxgPL0KSqT/b2UfJlEpWsgmlUsuUmwcvTfSuPeQNuXGIhpUL/i6J83ZEDQFyW5tFgCHYlfWW1rOOFtpFBfRPLpC60TG74ydSwudMoObO51Rr6ylGgvwuXeKpM6i1jdWdKf3IqMbZcMUnfeXaDnT4buzCTY3jieEyBivFD/l1gPi5QYJISKTQjuyOXKopub7g31zWMPO+1F09WA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Marc-André Lureau <marcandre.lureau@xxxxxxxxx>, Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>, Gerd Hoffmann <kraxel@xxxxxxxxxx>, "Michael S . Tsirkin" <mst@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Antonio Caggiano <quic_acaggian@xxxxxxxxxxx>, "Dr . David Alan Gilbert" <dgilbert@xxxxxxxxxx>, Robert Beckett <bob.beckett@xxxxxxxxxxxxx>, Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx>, Gert Wollny <gert.wollny@xxxxxxxxxxxxx>, Alex Bennée <alex.bennee@xxxxxxxxxx>, "qemu-devel@xxxxxxxxxx" <qemu-devel@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Gurchetan Singh <gurchetansingh@xxxxxxxxxxxx>, "ernunes@xxxxxxxxxx" <ernunes@xxxxxxxxxx>, Alyssa Ross <hi@xxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "Deucher, Alexander" <Alexander.Deucher@xxxxxxx>, "Stabellini, Stefano" <stefano.stabellini@xxxxxxx>, "Koenig, Christian" <Christian.Koenig@xxxxxxx>, "Ragiadakou, Xenia" <Xenia.Ragiadakou@xxxxxxx>, "Pelloux-Prayer, Pierre-Eric" <Pierre-eric.Pelloux-prayer@xxxxxxx>, "Huang, Honglei1" <Honglei1.Huang@xxxxxxx>, "Zhang, Julia" <Julia.Zhang@xxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Wed, 03 Jan 2024 08:49:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Dec 21, 2023 at 01:43:37PM +0800, Akihiko Odaki wrote:
> On 2023/12/19 22:27, Huang Rui wrote:
> > On Tue, Dec 19, 2023 at 08:35:27PM +0800, Akihiko Odaki wrote:
> >> On 2023/12/19 16:53, Huang Rui wrote:
> >>> Introduce a new virgl_gpu_resource data structure and helper functions
> >>> for virgl. It's used to add new member which is specific for virgl in
> >>> following patches of blob memory support.
> >>
> >> The name is ambigious. It should tell that it's specific for virgl.
> >
> > How about "virgl_resource" which inherits virtio_gpu_simple_resource? But
> > this name is exactly same with the name in virglrenderer.
>
> You can prefix it with virtio_gpu_virgl as virtio_gpu_virgl_init() and
> other functions do.
>
Thanks, will update it in V7.
Ray
|