[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 0/5] Make Big QEMU Lock naming consistent
- To: Stefan Hajnoczi <stefanha@xxxxxxxxxx>, qemu-devel@xxxxxxxxxx
- From: Akihiko Odaki <akihiko.odaki@xxxxxxxxxx>
- Date: Thu, 4 Jan 2024 21:10:26 +0900
- Cc: Hanna Reitz <hreitz@xxxxxxxxxx>, qemu-riscv@xxxxxxxxxx, Roman Bolshakov <rbolshakov@xxxxxxx>, Cédric Le Goater <clg@xxxxxxxx>, Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>, Eduardo Habkost <eduardo@xxxxxxxxxxx>, Thomas Huth <thuth@xxxxxxxxxx>, qemu-block@xxxxxxxxxx, Andrey Smirnov <andrew.smirnov@xxxxxxxxx>, Peter Maydell <peter.maydell@xxxxxxxxxx>, Huacai Chen <chenhuacai@xxxxxxxxxx>, Fam Zheng <fam@xxxxxxxxxx>, Gerd Hoffmann <kraxel@xxxxxxxxxx>, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>, John Snow <jsnow@xxxxxxxxxx>, Stafford Horne <shorne@xxxxxxxxx>, Weiwei Li <liwei1518@xxxxxxxxx>, Jean-Christophe Dubois <jcd@xxxxxxxxxxxxxxx>, Cameron Esfahani <dirty@xxxxxxxxx>, Alexander Graf <agraf@xxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Juan Quintela <quintela@xxxxxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>, Max Filippov <jcmvbkbc@xxxxxxxxx>, Daniel P. Berrangé <berrange@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Daniel Henrique Barboza <danielhb413@xxxxxxxxx>, Markus Armbruster <armbru@xxxxxxxxxx>, Peter Xu <peterx@xxxxxxxxxx>, Vladimir Sementsov-Ogievskiy <vsementsov@xxxxxxxxxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, qemu-s390x@xxxxxxxxxx, Jiri Slaby <jslaby@xxxxxxx>, Pavel Dovgalyuk <pavel.dovgaluk@xxxxxxxxx>, Eric Blake <eblake@xxxxxxxxxx>, Alex Bennée <alex.bennee@xxxxxxxxxx>, Aleksandar Rikalo <aleksandar.rikalo@xxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>, Sunil Muthuswamy <sunilmut@xxxxxxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>, Fabiano Rosas <farosas@xxxxxxx>, Michael Roth <michael.roth@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Jagannathan Raman <jag.raman@xxxxxxxxxx>, Mark Cave-Ayland <mark.cave-ayland@xxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Hyman Huang <yong.huang@xxxxxxxxxx>, Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Halil Pasic <pasic@xxxxxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxxxxx>, Song Gao <gaosong@xxxxxxxxxxx>, Kevin Wolf <kwolf@xxxxxxxxxx>, Ilya Leoshkevich <iii@xxxxxxxxxxxxx>, Artyom Tarasenko <atar4qemu@xxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, Reinoud Zandijk <reinoud@xxxxxxxxxx>, qemu-ppc@xxxxxxxxxx, Marcelo Tosatti <mtosatti@xxxxxxxxxx>, David Woodhouse <dwmw2@xxxxxxxxxxxxx>, Aurelien Jarno <aurelien@xxxxxxxxxxx>, Bin Meng <bin.meng@xxxxxxxxxxxxx>, qemu-arm@xxxxxxxxxx, Anthony Perard <anthony.perard@xxxxxxxxxx>, Leonardo Bras <leobras@xxxxxxxxxx>, Hailiang Zhang <zhanghailiang@xxxxxxxxxxx>, Harsh Prateek Bora <harshpb@xxxxxxxxxxxxx>, kvm@xxxxxxxxxxxxxxx, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Eric Farman <farman@xxxxxxxxxxxxx>, BALATON Zoltan <balaton@xxxxxxxxxx>, Liu Zhiwei <zhiwei_liu@xxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 04 Jan 2024 12:10:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2024/01/03 0:35, Stefan Hajnoczi wrote:
v3:
- Rebase
- Define bql_lock() macro on a single line [Akihiko Odaki]
v2:
- Rename APIs bql_*() [PeterX]
- Spell out "Big QEMU Lock (BQL)" in doc comments [PeterX]
- Rename "iolock" variables in hw/remote/mpqemu-link.c [Harsh]
- Fix bql_auto_lock() indentation in Patch 2 [Ilya]
- "with BQL taken" -> "with the BQL taken" [Philippe]
- "under BQL" -> "under the BQL" [Philippe]
The Big QEMU Lock ("BQL") has two other names: "iothread lock" and "QEMU global
mutex". The term "iothread lock" is easily confused with the unrelated --object
iothread (iothread.c).
This series updates the code and documentation to consistently use "BQL". This
makes the code easier to understand.
For the whole series,
Reviewed-by: Akihiko Odaki <akihiko.odaki@xxxxxxxxxx>
Thank you for sorting this out.
|