[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] xen/arm: bootfdt: Harden handling of malformed mem reserve map


  • To: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Michal Orzel <michal.orzel@xxxxxxx>
  • Date: Fri, 12 Jan 2024 09:56:24 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=raptorengineering.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=isriwWgkS0R+B3UXi/BtYK/HMKHNBQgThZOOLE3xvaU=; b=D12Eh12Bi2/y3U5D1RsJgtiYxiUma1eL60zIgq+8KXOaZYWXisyjvbnOXWHBDmAyWa86nF4DYy6akt/hueb3AQLmXi+gd4Dwqut6R25ogX7EywaeOrZWSwrmlhrDCWDbOfI3t34e0iPnuqR3zGiB9UXn1Vo1ldY9gjdzv9DiRBxO6U1yIvlsnIw1bsbFaiv9PuZPkfqbE7Ut65ZXWtNdGMz2eyN2f8LmN83Dvd5c1quPx+go812NjvPAiaKvhUZrassMvlN8+AY2HW/so2QB4o85ElgZYjtcvUIq6qeri9dWqHC28x1DA7MbFBCnmyp7pU7t1jYk9kgHCs/shYNQSg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xbxafc4Ez7I9mOY98c4UbrPlITg8wsEXutj9mjZZ1TAZudrB/AUFRTxZ+3wEzPMQP0lBbfrhG0c2ZkACebDAZP2s1u5zB6v3LnA5Wrt/sYLPNgv+iZJQEaryWSI0XFfUkAOKP9Ttcv8+obCt2YJtoUbTojP9BCcqCbVyW6BWcxaeLdHscOMewvnFbJCzPTEzBYAFOLEhwQBy9rigNBgV0cLXK1CTGpaKxCLDAKbymuoCHjozwBuYCvzoZ+aehfXQO3UCKS+i/NiUPQz3Z30Zso6LxoTwf0S6Llnrt8i1Y1sEPeMgwh8RETwMiv8OD1h6qd4QtyPRyb3b9UrmDN60eA==
  • Cc: Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Fri, 12 Jan 2024 08:56:43 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 12/01/2024 00:24, Shawn Anastasio wrote:
> 
> 
> The early_print_info routine in bootfdt.c incorrectly stores the result
> of a call to fdt_num_mem_rsv() in an unsigned int, which results in the
> negative error code being interpreted incorrectly in a subsequent loop
> in the case where the device tree is malformed. Fix this by properly
> checking the return code for an error and calling panic().
> 
> Signed-off-by: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>

~Michal




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.