Re: [PATCH v3 12/34] xen/riscv: introduce smp.h

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

On Thu, 2024-01-11 at 17:36 +0100, Jan Beulich wrote:
> On 22.12.2023 16:12, Oleksii Kurochko wrote:
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> > ---
> > Changes in V3:
> >  - drop cpu_is_offline() as it was moved to xen/smp.h.
> 
> Hmm.
> 
> >  - add SPDX.
> >  - drop unnessary #ifdef.
> >  - fix "No new line"
> >  - update the commit message
> 
> And another hmm.
It was removed word "asm/" before smp.h, but yes it is not correct to
write commit "message" should be "title".
I'll be more precise next time.

> 
> > --- /dev/null
> > +++ b/xen/arch/riscv/include/asm/smp.h
> > @@ -0,0 +1,28 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only */
> > +#ifndef __ASM_RISCV_SMP_H
> > +#define __ASM_RISCV_SMP_H
> > +
> > +#include <xen/cpumask.h>
> > +#include <xen/percpu.h>
> > +
> > +DECLARE_PER_CPU(cpumask_var_t, cpu_sibling_mask);
> > +DECLARE_PER_CPU(cpumask_var_t, cpu_core_mask);
> > +
> > +#define cpu_is_offline(cpu) unlikely(!cpu_online(cpu))
> 
> This clearly wasn't dropped (yet).
It looks like it was rebasing issue.
I'll handle that in the next patch version.
Thanks.

~ Oleksii