[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] xen/arm32: head: Move earlyprintk 'hex' to .rodata.idmap

To: Michal Orzel <michal.orzel@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
From: Julien Grall <julien@xxxxxxx>
Date: Mon, 15 Jan 2024 18:51:25 +0000
Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
Delivery-date: Mon, 15 Jan 2024 18:51:42 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi Michal,

On 15/01/2024 12:48, Michal Orzel wrote:

Thanks to 1ec3fe1f664f ("xen/arm32: head: Improve logging in head.S"),
we can now use PRINT_ID() macro to print messages when running on
identity mapping. For that, all the strings need to be part of the first
page that is mapped. This is not the case for a 'hex' string (used by
asm_putn when printing register values), which currently resides in
.rodata.str. Move it to .rodata.idmap to allow making use of print_reg
macro from anywhere (mostly to aid debugging).

Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>


Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall

References:
- [PATCH 0/2] xen/arm: head: early printk on 1:1 mapping
  - From: Michal Orzel
- [PATCH 1/2] xen/arm32: head: Move earlyprintk 'hex' to .rodata.idmap
  - From: Michal Orzel

Prev by Date: Re: [PATCH v3 22/34] xen/riscv: introduce regs.h
Next by Date: Re: [PATCH v12 09/15] vpci/header: program p2m with guest BAR view
Previous by thread: [PATCH 1/2] xen/arm32: head: Move earlyprintk 'hex' to .rodata.idmap
Next by thread: [PATCH 2/2] xen/arm64: head: Allow to use early printk while on 1:1 mapping
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.