Re: [PATCH v6 1/9] automation: ensure values in EXTRA_FIXED_RANDCONFIG are separated by new line

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

Hello Doug abd Stefano,

Could you please take a look at this patch and the next one [1] of this
patch series?

Thanks in advance.

[1]https://lore.kernel.org/xen-devel/db2c3d36b25b686bf07ac23f8ee8c879e0e9e81d.1703072575.git.oleksii.kurochko@xxxxxxxxx/

Best regards,
 Oleksii


On Wed, 2023-12-20 at 16:08 +0200, Oleksii Kurochko wrote:
> Kconfig tool expects each configuration to be on a new line.
> 
> The current version of the build script puts all of
> ${EXTRA_FIXED_RANDCONFIG}
> in a single line and configs are seperated by spaces.
> 
> As a result, only the first configuration in
> ${EXTRA_FIXED_RANDCONFIG} will
> be used.
> 
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> ---
> Changes in V6:
>  - The patch was introduced in this version of patch series.
> ---
>  automation/scripts/build | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/automation/scripts/build b/automation/scripts/build
> index b3c71fb6fb..13b043923d 100755
> --- a/automation/scripts/build
> +++ b/automation/scripts/build
> @@ -14,7 +14,7 @@ if [[ "${RANDCONFIG}" == "y" ]]; then
>  
>      # Append job-specific fixed configuration
>      if [[ -n "${EXTRA_FIXED_RANDCONFIG}" ]]; then
> -        echo "${EXTRA_FIXED_RANDCONFIG}" >>
> xen/tools/kconfig/allrandom.config
> +        sed "s/ /\n/g" <<< "${EXTRA_FIXED_RANDCONFIG}" >
> xen/tools/kconfig/allrandom.config
>      fi
>  
>      make -j$(nproc) -C xen
> KCONFIG_ALLCONFIG=tools/kconfig/allrandom.config randconfig
> @@ -28,9 +28,11 @@ else
>      echo "CONFIG_DEBUG=${debug}" >> xen/.config
>  
>      if [[ -n "${EXTRA_XEN_CONFIG}" ]]; then
> -        echo "${EXTRA_XEN_CONFIG}" >> xen/.config
> +        sed "s/ /\n/g" <<< "${EXTRA_XEN_CONFIG}" >> xen/.config
>      fi
>  
> +    cat xen/.config
> +
>      make -j$(nproc) -C xen olddefconfig
>  fi
>