Re: [PATCH v3 17/33] tools/xl: support new 9pfs backend xen-9pfsd

[Jürgen Groß <jgross@xxxxxxxx>]

On 15.01.24 16:14, Anthony PERARD wrote:
> On Thu, Jan 04, 2024 at 10:00:39AM +0100, Juergen Gross wrote:
> > @@ -2242,6 +2256,28 @@ void parse_config_data(const char *config_source,
> >   
> >               libxl_string_list_dispose(&pairs);
> >   
> > +            if (p9->type == LIBXL_P9_TYPE_UNKNOWN) {
> > +                p9->type = LIBXL_P9_TYPE_QEMU;
> The defaulting is normally done in libxl, so that it works for all users
> of libxl. Can this be done instead in libxl? Hopefully, it's enough to
> do it in libxl__device_p9_setdefault().
>
> Same question for the followup checks and default values.
I'll look into it.


Juergen